Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to supported Helix pools #10850

Closed
miniksa opened this issue Aug 2, 2021 · 1 comment · Fixed by #11028
Closed

Move to supported Helix pools #10850

miniksa opened this issue Aug 2, 2021 · 1 comment · Fixed by #11028
Assignees
@miniksa
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.11

Comments

@miniksa
Copy link
Member

miniksa commented Aug 2, 2021

Keith asked us to move our Helix stuff to the more supported pools. This represents that work.
@miniksa miniksa added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 2, 2021
@miniksa miniksa self-assigned this Aug 2, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 2, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 2, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.11 milestone Aug 2, 2021
@miniksa
Copy link
Member Author

miniksa commented Aug 5, 2021

I've managed to get this done inside the dev/miniksa/compilance branch along with #10735

@miniksa miniksa mentioned this issue Aug 24, 2021
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 24, 2021
@ghost ghost closed this as completed in #11028 Aug 25, 2021
@ghost ghost removed the In-PR This issue has a related PR label Aug 25, 2021
ghost pushed a commit that referenced this issue Aug 25, 2021
@miniksa
Move PGO Helix pools (#11028)
817f598 
Moves PGO runs to supported Helix pools. We need to match Microsoft-UI-XAML on which Helix pools we used for each type of activities.

## PR Checklist
* [x] Closes #10850
* [x] I work here
* [x] If it builds, it sits.

## Validation Steps Performed
* [x] Run PGO build against this branch
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 25, 2021
DHowett pushed a commit that referenced this issue Aug 26, 2021
@miniksa @DHowett
Move PGO Helix pools (#11028)
2366427 
Moves PGO runs to supported Helix pools. We need to match Microsoft-UI-XAML on which Helix pools we used for each type of activities.

## PR Checklist
* [x] Closes #10850
* [x] I work here
* [x] If it builds, it sits.

## Validation Steps Performed
* [x] Run PGO build against this branch

(cherry picked from commit 817f598)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miniksa miniksa

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.11
Development

Successfully merging a pull request may close this issue.

Move PGO Helix pools microsoft/terminal
2 participants
@miniksa @zadjii-msft