Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should be able to auto-minimize on focus lost #10660

Closed
Tracked by #8888
, #10448
...
zadjii-msft opened this issue Jul 14, 2021 · 1 comment · Fixed by #13478
Closed
Tracked by #8888
, #10448
...

Terminal should be able to auto-minimize on focus lost #10660

zadjii-msft opened this issue Jul 14, 2021 · 1 comment · Fixed by #13478
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Hey!

Not sure if I missed a flag for the config somewhere, but it'd be grand if the quake mode could auto minimize itself when it loses focus. As is, I have to hit the hotkey twice to hide the window.

Thanks for the hard work.

Originally posted by @digiwombat in #8888 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 14, 2021
@zadjii-msft zadjii-msft mentioned this issue Jul 14, 2021
Open
61 tasks
@zadjii-msft zadjii-msft added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 14, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 14, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 14, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 22, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
This was referenced Apr 18, 2022
Open
Open
@davidegiacometti davidegiacometti mentioned this issue Jul 10, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 10, 2022
@ghost ghost closed this as completed in #13478 Jul 14, 2022
ghost pushed a commit that referenced this issue Jul 14, 2022
@davidegiacometti
Setting for hide window when it loses focus (#13478)
56016c9 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Added setting for for hide window when it loses focus.
Works on normal window and quake window.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #10660
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

- Enable **Settings > Appearance > Automatically hide window**
- Terminal window should be minimized on taskbar when it loses focus
- Quake window should be minimized on system tray when it loses focus
- Enable also **Settings > Appearance > Hide Terminal in the notification area when it is minimized**
- Terminal window should be minimized on system tray when it loses focus
- Quake window should be minimized on system tray when it loses focus
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 14, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13478, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Jan 19, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Setting for hide window when it loses focus
2 participants
@DHowett @zadjii-msft