Skip to content

Commit

Permalink
Update the quakeMode action name (#10641)
Browse files Browse the repository at this point in the history
As in #10210. This string was already in the resources (so it should already be localized!)

* closes #10210.
* I work here
* tests? we don't got no stinkin' tests

![image](https://user-images.githubusercontent.com/18356694/125360281-45ddd280-e331-11eb-9798-6f087f33af2f.png)

(cherry picked from commit 59166fa)
  • Loading branch information
zadjii-msft authored and DHowett committed Jul 12, 2021
1 parent d5ff31c commit fd4af02
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/cascadia/TerminalSettingsModel/ActionArgs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,14 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation

winrt::hstring GlobalSummonArgs::GenerateName() const
{
// GH#10210 - Is this action literally the same thing as the `quakeMode`
// action? That has a special name.
static const auto quakeModeArgs{ std::get<0>(GlobalSummonArgs::QuakeModeFromJson(Json::Value::null)) };
if (quakeModeArgs.Equals(*this))
{
return RS_(L"QuakeModeCommandKey");
}

std::wstringstream ss;
ss << std::wstring_view(RS_(L"GlobalSummonCommandKey"));

Expand Down

0 comments on commit fd4af02

Please sign in to comment.