Skip to content

Commit

Permalink
Update tests to account for removed APIs.
Browse files Browse the repository at this point in the history
  • Loading branch information
j4james committed May 2, 2022
1 parent d3ce1a0 commit aa7bd41
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 19 deletions.
18 changes: 9 additions & 9 deletions src/cascadia/UnitTests_TerminalCore/SelectionTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ namespace TerminalCoreUnitTests
const auto burrito = L"\xD83C\xDF2F";

// Insert wide glyph at position (4,10)
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(burrito);

// Simulate click at (x,y) = (5,10)
Expand All @@ -417,7 +417,7 @@ namespace TerminalCoreUnitTests
const auto burrito = L"\xD83C\xDF2F";

// Insert wide glyph at position (4,10)
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(burrito);

// Simulate click at (x,y) = (5,10)
Expand All @@ -440,11 +440,11 @@ namespace TerminalCoreUnitTests
const auto burrito = L"\xD83C\xDF2F";

// Insert wide glyph at position (4,10)
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(burrito);

// Insert wide glyph at position (7,11)
term.SetCursorPosition({ 7, 11 });
term.GetTextBuffer().GetCursor().SetPosition({ 7, 11 });
term.Write(burrito);

// Simulate ALT + click at (x,y) = (5,8)
Expand Down Expand Up @@ -496,7 +496,7 @@ namespace TerminalCoreUnitTests

// Insert text at position (4,10)
const std::wstring_view text = L"doubleClickMe";
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(text);

// Simulate double click at (x,y) = (5,10)
Expand Down Expand Up @@ -540,7 +540,7 @@ namespace TerminalCoreUnitTests

// Insert text at position (4,10)
const std::wstring_view text = L"C:\\Terminal>";
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(text);

// Simulate click at (x,y) = (15,10)
Expand Down Expand Up @@ -568,7 +568,7 @@ namespace TerminalCoreUnitTests

// Insert text at position (4,10)
const std::wstring_view text = L"doubleClickMe dragThroughHere";
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(text);

// Simulate double click at (x,y) = (5,10)
Expand Down Expand Up @@ -597,7 +597,7 @@ namespace TerminalCoreUnitTests

// Insert text at position (21,10)
const std::wstring_view text = L"doubleClickMe dragThroughHere";
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(text);

// Simulate double click at (x,y) = (21,10)
Expand Down Expand Up @@ -685,7 +685,7 @@ namespace TerminalCoreUnitTests

// Insert text at position (4,10)
const std::wstring_view text = L"doubleClickMe dragThroughHere";
term.SetCursorPosition({ 4, 10 });
term.GetTextBuffer().GetCursor().SetPosition({ 4, 10 });
term.Write(text);

// Step 1: Create a selection on "doubleClickMe"
Expand Down
20 changes: 10 additions & 10 deletions src/cascadia/UnitTests_TerminalCore/TerminalApiTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ void TerminalApiTest::SetColorTableEntry()
auto settings = winrt::make<MockTermSettings>(100, 100, 100);
term.UpdateSettings(settings);

VERIFY_NO_THROW(term.SetColorTableEntry(0, 100));
VERIFY_NO_THROW(term.SetColorTableEntry(128, 100));
VERIFY_NO_THROW(term.SetColorTableEntry(255, 100));
VERIFY_NO_THROW(term._renderSettings.SetColorTableEntry(0, 100));
VERIFY_NO_THROW(term._renderSettings.SetColorTableEntry(128, 100));
VERIFY_NO_THROW(term._renderSettings.SetColorTableEntry(255, 100));

VERIFY_THROWS(term.SetColorTableEntry(512, 100), std::exception);
VERIFY_THROWS(term._renderSettings.SetColorTableEntry(512, 100), std::exception);
}

// Terminal::_WriteBuffer used to enter infinite loops under certain conditions.
Expand Down Expand Up @@ -152,7 +152,7 @@ void TerminalApiTest::CursorVisibility()
VERIFY_IS_TRUE(term._mainBuffer->GetCursor().IsOn());
VERIFY_IS_TRUE(term._mainBuffer->GetCursor().IsBlinkingAllowed());

term.SetCursorVisibility(false);
term.GetTextBuffer().GetCursor().SetIsVisible(false);
VERIFY_IS_FALSE(term._mainBuffer->GetCursor().IsVisible());
VERIFY_IS_TRUE(term._mainBuffer->GetCursor().IsOn());
VERIFY_IS_TRUE(term._mainBuffer->GetCursor().IsBlinkingAllowed());
Expand Down Expand Up @@ -242,19 +242,19 @@ void TerminalApiTest::CheckDoubleWidthCursor()
stateMachine.ProcessString(doubleWidthText);

// The last 'A'
term.SetCursorPosition({ 97, 0 });
cursor.SetPosition({ 97, 0 });
VERIFY_IS_FALSE(term.IsCursorDoubleWidth());

// This and the next CursorPos are taken up by '我‘
term.SetCursorPosition({ 98, 0 });
cursor.SetPosition({ 98, 0 });
VERIFY_IS_TRUE(term.IsCursorDoubleWidth());
term.SetCursorPosition({ 99, 0 });
cursor.SetPosition({ 99, 0 });
VERIFY_IS_TRUE(term.IsCursorDoubleWidth());

// This and the next CursorPos are taken up by ’愛‘
term.SetCursorPosition({ 0, 1 });
cursor.SetPosition({ 0, 1 });
VERIFY_IS_TRUE(term.IsCursorDoubleWidth());
term.SetCursorPosition({ 1, 1 });
cursor.SetPosition({ 1, 1 });
VERIFY_IS_TRUE(term.IsCursorDoubleWidth());
}

Expand Down

0 comments on commit aa7bd41

Please sign in to comment.