Skip to content

Commit

Permalink
Fix typos found by codespell (#12475)
Browse files Browse the repository at this point in the history
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

Fix typos found by codespell. Some of it in documentation and user-visible text, mostly in code comments. While I understand you might not be interested in fixing code comments, one of the reasons being extra noise in git history, kindly note that most spell checking tools do not discriminate between documentation and code comments. So it's easier to fix everything for long maintenance.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [ ] Closes #xxx
* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Tests added/passed
* [X] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: [#501](MicrosoftDocs/terminal#501)
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

I have checked and re-checked all changes.
  • Loading branch information
DimitriPapadopoulos committed Feb 17, 2022
1 parent d36cb75 commit 71c7556
Show file tree
Hide file tree
Showing 42 changed files with 55 additions and 59 deletions.
4 changes: 0 additions & 4 deletions .github/actions/spelling/expect/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,6 @@ dxp
dxsm
dxttbmp
Dyreen
eachother
eaf
EASTEUROPE
ECH
Expand Down Expand Up @@ -829,7 +828,6 @@ FORCEOFFFEEDBACK
FORCEONFEEDBACK
FORCEV
foreach
forground
fprintf
framebuffer
FRAMECHANGED
Expand Down Expand Up @@ -1698,7 +1696,6 @@ outfile
Outof
OUTOFCONTEXT
OUTOFMEMORY
outout
Outptr
outstr
OVERLAPPEDWINDOW
Expand Down Expand Up @@ -1850,7 +1847,6 @@ pragma
prc
prealigned
prebuilt
precendence
precomp
prect
prefast
Expand Down
2 changes: 1 addition & 1 deletion doc/Niksa.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Given that we're using Xaml islands to host a modern UI and stitching a DirectX

Now, the obvious followup question is _"why can't you have one elevated connection in a tab next to a non-elevated connection?"_ This is where @sba923 should pick up reading (:smile:). I'm probably going to cover some things that you (@robomac) know already.

[2] When you have two windows on the same desktop in the same window station, they can communicate with eachother. I can use `SendKeys` easily through `WScript.Shell` to send keyboard input to any window that the shell can see.
[2] When you have two windows on the same desktop in the same window station, they can communicate with each other. I can use `SendKeys` easily through `WScript.Shell` to send keyboard input to any window that the shell can see.

Running a process elevated _severs_ that connection. The shell can't see the elevated window. No other program at the same integrity level as the shell can see the elevated window. Even if it has its window handle, it can't really interact with it. This is also why you can't drag/drop from explorer into notepad if notepad is running elevated. Only another elevated process can interact with another elevated window.

Expand Down
2 changes: 1 addition & 1 deletion doc/cascadia/Unittesting-CppWinRT-Xaml.md
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ this:
</ItemDefinitionGroup>
```

Again, verify the correct paths to your dependant C++/WinRT dlls, as they may be
Again, verify the correct paths to your dependent C++/WinRT dlls, as they may be
different than the above

#### Activating the manifest from TAEF
Expand Down
2 changes: 1 addition & 1 deletion doc/specs/#1790 - Font features and axes-spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Should not affect security.

### Reliability

Aside from additional parsing required for the settings file (which inherently offers more locations for parsing to fail), we need to be careful about badly formed/non-existant feature tags or axes specified in the user-defined dictionaries. We must make sure to ignore such declarations (perhaps alongside emitting a warning to the user) and only apply those that are correctly formed and exist.
Aside from additional parsing required for the settings file (which inherently offers more locations for parsing to fail), we need to be careful about badly formed/non-existent feature tags or axes specified in the user-defined dictionaries. We must make sure to ignore such declarations (perhaps alongside emitting a warning to the user) and only apply those that are correctly formed and exist.

### Compatibility

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ So `focusPane(target=1, direction=up)` will attempt to focus the pane above pane

> 👉 **NOTE**: At this point, the author considered "Do we even want a separate
> action to engage the tab switcher with panes expanded?" Perhaps panes being
> visible in the tab switcher is just part fo the tab switcher's behavior. Maybe
> visible in the tab switcher is just part of the tab switcher's behavior. Maybe
> there shouldn't be a separate "open the tab switcher with the panes expanded
> to the pane I'm currently on, and the panes listed in MRU order" action.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ following behaviors:
* `false`: If the current window is elevated, try to create a new unelevated
window to host this connection.
We could always re-introduce this setting, to supercede `elevate`.
We could always re-introduce this setting, to supersede `elevate`.
### Change profile appearance for elevated windows
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,7 @@ elevated windows, when they trust the extension. We could have an additional set
of settings the user could use to enable certain extensions in elevated windows.
However, this setting cannot live in the normal `settings.json` or even
`state.json` (see [#7972], since those files are writable by any medium-IL
process. Instead, this setting would ned to live in a separate file that's
process. Instead, this setting would need to live in a separate file that's
protected to only be writable by elevated processes. This would ensure that an
attacker could not just add their extension to the list of white-listed
extensions. When the settings UI wants to modify that setting, it'll need to
Expand Down
2 changes: 1 addition & 1 deletion doc/specs/#6899 - Action IDs/#6899 - Action IDs.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This spec was largely inspired by the following diagram from @DHowett:
![figure 1](data-mockup.png)

The goal is to introduce an `id` parameter by which actions could be uniquely
refered to. If we'd ever like to use an action outside the list of `actions`, we
referred to. If we'd ever like to use an action outside the list of `actions`, we
can simply refer to the action's ID, allowing the user to only define the action
_once_.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def cloneGraph(oldSource, newSource, visited):
for old in oldSource.adj:

# Below check is for backtracking, so new
# nodes don't get initialized everytime
# nodes don't get initialized every time
if clone is None or(clone is not None and clone.key != old.key):
clone = Node(old.key, [])
newSource.adj.append(clone)
Expand Down
2 changes: 1 addition & 1 deletion doc/specs/TerminalSettings-spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ VS needs to be able to persist settings just as a simple set of global settings.
When the application needs to retrieve these settings, they need to use them as a tripartite structure: frontend-component-terminal settings.

Each frontend will have its own set of settings.
Each component implementation will also ned to have some settings that control it.
Each component implementation will also need to have some settings that control it.
The terminal also will have some settings specific to the terminal.

### Globals and Profiles
Expand Down
2 changes: 1 addition & 1 deletion doc/specs/drafts/#1256 - Tab tearoff.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ There's a few areas to study here.

#### Communicating the launch
For the parameters passing, I see a few options:
1. `conhost.exe` can look up the package registration for `wt.exe` and call an entrypoint with arguments. This could be adapted to instead look up which package is registered as the default one instead of `wt.exe` for third party hosts. We would have to build provisions into the OS to select this, or use some sort of publically documented registry key mechanism. Somewhat gross.
1. `conhost.exe` can look up the package registration for `wt.exe` and call an entrypoint with arguments. This could be adapted to instead look up which package is registered as the default one instead of `wt.exe` for third party hosts. We would have to build provisions into the OS to select this, or use some sort of publicly documented registry key mechanism. Somewhat gross.
1. `conhost.exe` can call the execution alias with parameters. WSL distro launchers use this.
1. We can define a protocol handler for these sorts of connections and let `wt.exe` register for it. Protocol handlers are already well supported and understood both by classic applications and by packaged/modern applications on Windows. They must have provisions to communicate at least some semblance of argument data as well. This is the route I'd probably prefer. `ms-term://incoming/<session-id>` or something like that. The receiving `wt.exe` can contact the manager process (or set one up if it is the first) and negotiate receiving the session that was specified into a new tab.

Expand Down
2 changes: 1 addition & 1 deletion doc/specs/drafts/#997 Non-Terminal-Panes.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ is a bigger discussion than the feature at hand, however.
### Performance, Power, and Efficiency

decide to host a WebView in a pane, then it surely could impact these measures.
I don't believe this will have a noticable impact _on its own_. Should the user
I don't believe this will have a noticeable impact _on its own_. Should the user
However, I leave that discussion to the implementation of the actual alternative
pane content itself.

Expand Down
2 changes: 1 addition & 1 deletion samples/ConPTY/MiniTerm/MiniTerm/PseudoConsole.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ internal static PseudoConsole Create(SafeFileHandle inputReadSide, SafeFileHandl
0, out IntPtr hPC);
if(createResult != 0)
{
throw new InvalidOperationException("Could not create psuedo console. Error Code " + createResult);
throw new InvalidOperationException("Could not create pseudo console. Error Code " + createResult);
}
return new PseudoConsole(hPC);
}
Expand Down
4 changes: 2 additions & 2 deletions samples/ReadConsoleInputStream/ReadConsoleInputStream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public override int Read(byte[] buffer, int offset, int count)
if (record.EventType != Kernel32.EVENT_TYPE.FOCUS_EVENT)
{
// I assume success adding records - this is not so critical
// if it is critical to you, loop on this with a miniscule delay
// if it is critical to you, loop on this with a minuscule delay
_nonKeyEvents.TryAdd(record);
}
}
Expand Down Expand Up @@ -195,4 +195,4 @@ private void ValidateRead(byte[] buffer, int offset, int count)
if (!CanRead) throw new NotSupportedException("Get read not supported.");
}
}
}
}
2 changes: 1 addition & 1 deletion src/buffer/out/textBuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1751,7 +1751,7 @@ const TextBuffer::TextAndColor TextBuffer::GetText(const bool includeCRLF,

if (copyTextColor)
{
// cant see CR/LF so just use black FG & BK
// can't see CR/LF so just use black FG & BK
COLORREF const Blackness = RGB(0x00, 0x00, 0x00);
selectionFgAttr.push_back(Blackness);
selectionFgAttr.push_back(Blackness);
Expand Down
4 changes: 2 additions & 2 deletions src/cascadia/TerminalApp/TerminalPage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ namespace winrt::TerminalApp::implementation
// elevated window.
if (!_startupActions || IsElevated() || _shouldStartInboundListener)
{
// there arent startup actions, or we're elevated. In that case, go for it.
// there aren't startup actions, or we're elevated. In that case, go for it.
return false;
}

Expand Down Expand Up @@ -1219,7 +1219,7 @@ namespace winrt::TerminalApp::implementation
// message without vkey or scanCode if a user drags a tab.
// The KeyChord constructor has a debug assertion ensuring that all KeyChord
// either have a valid vkey/scanCode. This is important, because this prevents
// accidential insertion of invalid KeyChords into classes like ActionMap.
// accidental insertion of invalid KeyChords into classes like ActionMap.
if (!vkey && !scanCode)
{
return;
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalApp/TerminalTab.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1415,7 +1415,7 @@ namespace winrt::TerminalApp::implementation
selectedTabBrush.Color(color);

// currently if a tab has a custom color, a deselected state is
// signified by using the same color with a bit ot transparency
// signified by using the same color with a bit of transparency
auto deselectedTabColor = color;
deselectedTabColor.A = 64;
deselectedTabBrush.Color(deselectedTabColor);
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalControl/TermControl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation
// message without vkey or scanCode if a user drags a tab.
// The KeyChord constructor has a debug assertion ensuring that all KeyChord
// either have a valid vkey/scanCode. This is important, because this prevents
// accidential insertion of invalid KeyChords into classes like ActionMap.
// accidental insertion of invalid KeyChords into classes like ActionMap.
if (!vkey && !scanCode)
{
e.Handled(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ JSON_ENUM_MAPPER(::winrt::Microsoft::Terminal::Settings::Model::CloseOnExitMode)
};

// This specialization isn't using JSON_ENUM_MAPPER because we need to have a different
// value type (unsinged int) and return type (FontWeight struct). JSON_ENUM_MAPPER
// value type (unsigned int) and return type (FontWeight struct). JSON_ENUM_MAPPER
// expects that the value type _is_ the return type.
template<>
struct ::Microsoft::Terminal::Settings::Model::JsonUtils::ConversionTrait<::winrt::Windows::UI::Text::FontWeight> :
Expand Down
6 changes: 3 additions & 3 deletions src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// This test class creates an in-proc conpty host as well as a Terminal, to
// validate that strings written to the conpty create the same response on the
// terminal end. Tests can be written that validate both the contents of the
// host buffer as well as the terminal buffer. Everytime that
// host buffer as well as the terminal buffer. Every time that
// `renderer.PaintFrame()` is called, the tests will validate the expected
// output, and then flush the output of the VtEngine straight to the Terminal.

Expand Down Expand Up @@ -392,7 +392,7 @@ void ConptyRoundtripTests::WriteTwoLinesUsesNewline()
void ConptyRoundtripTests::WriteAFewSimpleLines()
{
Log::Comment(NoThrowString().Format(
L"Write more lines of outout. We should use \r\n to move the cursor"));
L"Write more lines of output. We should use \r\n to move the cursor"));

auto& g = ServiceLocator::LocateGlobals();
auto& renderer = *g.pRender;
Expand Down Expand Up @@ -3047,7 +3047,7 @@ void ConptyRoundtripTests::NewLinesAtBottomWithBackground()
// Line 2 chars: ____#_________#___ (break)
// Line 2 attrs: BBBBBBBBBBBBBBDDDD (First spacesToPrint+5 are blue BG, then default attrs)
// [<----->]
// This number of spaces controled by spacesToPrint
// This number of spaces controlled by spacesToPrint
if (i > 0)
{
sm.ProcessString(L"\r\n");
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/WindowsTerminal/AppHost.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ void AppHost::Initialize()
}

// Method Description:
// - Called everytime when the active tab's title changes. We'll also fire off
// - Called every time when the active tab's title changes. We'll also fire off
// a window message so we can update the window's title on the main thread,
// though we'll only do so if the settings are configured for that.
// Arguments:
Expand Down
6 changes: 3 additions & 3 deletions src/cascadia/WindowsTerminal/IslandWindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ void IslandWindow::_OnGetMinMaxInfo(const WPARAM /*wParam*/, const LPARAM lParam
}

// Method Description:
// - Helper function that calculates a singe dimension value, given initialWindow and nonClientSizes
// - Helper function that calculates a single dimension value, given initialWindow and nonClientSizes
// Arguments:
// - isWidth: parameter to pass to SnapDimensionCallback.
// True if the method is invoked for width computation, false if for height.
Expand Down Expand Up @@ -1332,7 +1332,7 @@ void IslandWindow::_dropdownWindow(const uint32_t dropdownDuration,
{
// First, get the window that's currently in the foreground. We'll need
// _this_ window to be able to appear on top of. If we just use
// GetForegroundWindow afer the SetWindowPlacement call, _we_ will be the
// GetForegroundWindow after the SetWindowPlacement call, _we_ will be the
// foreground window.
const auto oldForegroundWindow = GetForegroundWindow();

Expand Down Expand Up @@ -1389,7 +1389,7 @@ void IslandWindow::_globalActivateWindow(const uint32_t dropdownDuration,
{
// First, get the window that's currently in the foreground. We'll need
// _this_ window to be able to appear on top of. If we just use
// GetForegroundWindow afer the SetWindowPlacement/ShowWindow call, _we_
// GetForegroundWindow after the SetWindowPlacement/ShowWindow call, _we_
// will be the foreground window.
const auto oldForegroundWindow = GetForegroundWindow();

Expand Down
2 changes: 1 addition & 1 deletion src/host/popup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ using Microsoft::Console::Interactivity::ServiceLocator;
// - Creates an object representing an interactive popup overlay during cooked mode command line editing.
// - NOTE: Modifies global popup count (and adjusts cursor visibility as appropriate.)
// Arguments:
// - screenInfo - Reference to screen on which the popup should be drawn/overlayed.
// - screenInfo - Reference to screen on which the popup should be drawn/overlaid.
// - proposedSize - Suggested size of the popup. May be adjusted based on screen size.
Popup::Popup(SCREEN_INFORMATION& screenInfo, const COORD proposedSize) :
_screenInfo(screenInfo),
Expand Down
2 changes: 1 addition & 1 deletion src/host/screenInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2711,7 +2711,7 @@ const FontInfo& SCREEN_INFORMATION::GetCurrentFont() const noexcept
// - Gets the desired font of the screen buffer. If we try loading this font and
// have to fallback to another, then GetCurrentFont()!=GetDesiredFont().
// We store this separately, so that if we need to reload the font, we can
// try again with our prefered font info (in the desired font info) instead
// try again with our preferred font info (in the desired font info) instead
// of re-using the looked up value from before.
// Arguments:
// - <none>
Expand Down
2 changes: 1 addition & 1 deletion src/host/selectionInput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ bool Selection::_HandleColorSelection(const INPUT_KEY_INFO* const pInputKeyInfo)
const WORD wVirtualKeyCode = pInputKeyInfo->GetVirtualKey();

// It's a numeric key, a text mode buffer and the color selection regkey is set,
// then check to see if the user want's to color the selection or search and
// then check to see if the user wants to color the selection or search and
// highlight the selection.
bool fAltPressed = pInputKeyInfo->IsAltPressed();
bool fShiftPressed = pInputKeyInfo->IsShiftPressed();
Expand Down
2 changes: 1 addition & 1 deletion src/host/ut_host/ScreenBufferTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4536,7 +4536,7 @@ void ScreenBufferTests::ScrollLines256Colors()

int scrollType;
int colorStyle;
VERIFY_SUCCEEDED(TestData::TryGetValue(L"scrollType", scrollType), L"controls whether to use InsertLines, DeleteLines ot ReverseLineFeed");
VERIFY_SUCCEEDED(TestData::TryGetValue(L"scrollType", scrollType), L"controls whether to use InsertLines, DeleteLines or ReverseLineFeed");
VERIFY_SUCCEEDED(TestData::TryGetValue(L"colorStyle", colorStyle), L"controls whether to use the 16 color table, 256 table, or RGB colors");

// This test is largely taken from repro code from
Expand Down
6 changes: 3 additions & 3 deletions src/inc/consoletaeftemplates.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ Revision History:
#include <til/bit.h>

// Helper for declaring a variable to store a TEST_METHOD_PROPERTY and get it's value from the test metadata
#define INIT_TEST_PROPERTY(type, identifer, description) \
type identifer; \
VERIFY_SUCCEEDED(TestData::TryGetValue(L## #identifer, identifer), description);
#define INIT_TEST_PROPERTY(type, identifier, description) \
type identifier; \
VERIFY_SUCCEEDED(TestData::TryGetValue(L## #identifier, identifier), description);

// Thinking of adding a new VerifyOutputTraits for a new type? MAKE SURE that
// you include this header (or at least the relevant definition) before _every_
Expand Down
2 changes: 1 addition & 1 deletion src/interactivity/win32/Clipboard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ bool Clipboard::FilterCharacterOnPaste(_Inout_ WCHAR* const pwch)
{
switch (*pwch)
{
// swallow tabs to prevent inadvertant tab expansion
// swallow tabs to prevent inadvertent tab expansion
case UNICODE_TAB:
{
fAllowChar = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1667,7 +1667,7 @@ class UiaTextRangeTests
VERIFY_SUCCEEDED(utr->GetAttributeValue(UIA_UnderlineStyleAttributeId, &result));
VERIFY_ARE_EQUAL(TextDecorationLineStyle_Single, result.lVal);

// Double underline (double supercedes single)
// Double underline (double supersedes single)
attr.SetDoublyUnderlined(true);
updateBuffer(attr);
VERIFY_SUCCEEDED(utr->GetAttributeValue(UIA_UnderlineStyleAttributeId, &result));
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/dx/CustomTextLayout.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ CATCH_RETURN();
// Arguments:
// - <none>
// Return Value:
// - Mutable reference ot the current run.
// - Mutable reference of the current run.
[[nodiscard]] CustomTextLayout::LinkedRun& CustomTextLayout::_GetCurrentRun()
{
return _runs.at(_runIndex);
Expand Down
Loading

0 comments on commit 71c7556

Please sign in to comment.