Skip to content

Commit

Permalink
Fix SizeOfSet and PositionInSet for 'Open JSON File' nav item (#12286)
Browse files Browse the repository at this point in the history
## Summary of the Pull Request
According to microsoft/microsoft-ui-xaml#1971, `PaneFooter` does not set the `SizeOfSet` or `PositionInSet` properties. However, `FooterMenuItems` does and works for our scenario. So we just replaced `PaneFooter` with `FooterMenuItems`.

Will handle #11154 upon verification from the accessibility team.

## Validation Steps Performed
✅ Verified using Accessibility Insights
✅ "Open Json File" button can still be invoked and keyboard navigated to as expected
  • Loading branch information
carlos-zamora committed Jan 31, 2022
1 parent eb75597 commit 2861b41
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/cascadia/TerminalSettingsEditor/MainPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@

</muxc:NavigationView.MenuItems>

<muxc:NavigationView.PaneFooter>
<muxc:NavigationView.FooterMenuItems>
<!-- The OpenJson item needs both Tapped and KeyDown handler -->
<muxc:NavigationViewItem x:Name="OpenJsonNavItem"
x:Uid="Nav_OpenJSON"
Expand All @@ -129,7 +129,7 @@
<FontIcon Glyph="&#xE713;" />
</muxc:NavigationViewItem.Icon>
</muxc:NavigationViewItem>
</muxc:NavigationView.PaneFooter>
</muxc:NavigationView.FooterMenuItems>

<Grid Margin="0,-30,0,0">
<Grid.RowDefinitions>
Expand Down

0 comments on commit 2861b41

Please sign in to comment.