Skip to content

Commit

Permalink
use PMR pool for the vector in the bitmap so we're not alloc/freeing …
Browse files Browse the repository at this point in the history 
…over and over when we know we're about to just rebuild a vector of more runs. optional will destroy the internal vector.
  • Loading branch information
@miniksa
miniksa committed Jan 8, 2021
1 parent d8cbaed commit 1882623
Showing 1 changed file with 17 additions and 4 deletions.
21 changes: 17 additions & 4 deletions src/inc/til/bitmap.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,15 @@ namespace til // Terminal Implementation Library. Also: "Today I Learned"
return const_iterator(_bits, _sz, _sz.area());
}

const std::vector<til::rectangle>& runs() const
const gsl::span<const til::rectangle> runs() const
{
// If we don't have cached runs, rebuild.
if (!_runs.has_value())
{
_runs.emplace(begin(), end());
_runs.emplace(begin(), end(), &_getPool());
}

// Return a reference to the runs.
// Return the runs.
return _runs.value();
}

Expand Down Expand Up @@ -454,7 +454,20 @@ namespace til // Terminal Implementation Library. Also: "Today I Learned"
til::rectangle _rc;
dynamic_bitset<> _bits;

mutable std::optional<std::vector<til::rectangle>> _runs;
// Memory pooling to save alloc/free work to the OS.
// The optional below will destroy the internal vector when it is reset.
// But that will do a whole free to the OS when we know we're probably going to rebuild
// it very shortly for the new set of runs. We could make a pair bool/vector
// or continue to use the optional with a PMR vector inside.
// It's static because we only need one pool to manage memory
// for all vectors of rectangles no matter which bitmap instance is making them.
static std::pmr::unsynchronized_pool_resource& _getPool()
{
static std::pmr::unsynchronized_pool_resource pool;
return pool;
}

mutable std::optional<std::pmr::vector<til::rectangle>> _runs;

#ifdef UNIT_TESTING
friend class ::BitmapTests;
Expand Down

1 comment on commit 1882623

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New misspellings found, please review:

  • codepath
To accept these changes, run the following commands 
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect/5757ec679b03a4240130c3c53766c91bbc5cd6a7.txt
.github/actions/spell-check/expect/655f007265b351e140d20b3976792523ad689241.txt
.github/actions/spell-check/expect/a129ff14ec985d6b7bf09e296a831c955d41040b.txt
.github/actions/spell-check/expect/alphabet.txt
.github/actions/spell-check/expect/expect.txt
.github/actions/spell-check/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"Remoting rgdx "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect/1882623d96d9aa35dba784907c584bb1783d536c.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"codepath remoting "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check/expect || echo '... you want to ensure .github/actions/spell-check/expect/1882623d96d9aa35dba784907c584bb1783d536c.txt is added to your repository...'
✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spell-check/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Please sign in to comment.