feat(Mover): Connected Movers. #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
reviewed
Aug 28, 2024
| groupper: {}, | ||
| mover: { | ||
| direction: MoverDirections.Vertical, | ||
| connected: MoverConnections.Parent, |
There was a problem hiding this comment.
why are Child and Parent relationships both needed for connected movers? Is there a scenario where you can have a parent mover with Child and only a subset of movers will use Parent?
ling1726
reviewed
Aug 28, 2024
| </div> | ||
|
|
||
| <div | ||
| tabIndex={0} |
There was a problem hiding this comment.
what happens when a connected mover is not focusable?
ling1726
reviewed
Aug 28, 2024
| }, | ||
| })} | ||
| > | ||
| <button>Button1</button> |
There was a problem hiding this comment.
Please update button names to be a bit more specific to their level of nesting
i.e. Button1L3
ling1726
reviewed
Aug 28, 2024
| <div | ||
| {...getTabsterAttribute({ | ||
| mover: { | ||
| direction: MoverDirections.Horizontal, |
There was a problem hiding this comment.
what happens when parent and child movers share the same direction?
ling1726
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to connect nested Movers via DOM hierarchy so that the parent Movers can continue handling the key press when the child Mover couldn't find new focus target.