Bump SMO to 170.9.0 #1766
Merged
Bump SMO to 170.9.0 #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
kburtram,
shueybubbles,
aasimkhan30 and
cheenamalhotra
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
shueybubbles
approved these changes
Nov 22, 2022
| @@ -28,14 +28,15 @@ public DatabaseTreeNode(ServerNode serverNode, string databaseName): this() | |||
| // We detect that here and fall back to master | |||
| if (db.State == SqlSmoState.Creating && !IsDWGen3(db)) | |||
| { | |||
There was a problem hiding this comment.
log a bug to only do this fallback for non-Azure connections
Charles-Gagnon
added a commit
that referenced
this pull request
Nov 22, 2022
* Add logging * SMO 170.9.0
Charles-Gagnon
added a commit
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/azuredatastudio#21245
This is reverting the change in SMO that's breaking the table expansion, see the issue for more details
I also added a logging statement to make explicitly clear when we're falling back to master