Use old dotnet embedded resource convention #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartguest
changed the title
|
I can't seem to repro this error myself - do you know why that is? |
|
@Charles-Gagnon I'm not sure, but on a regular installation of ADS, if you try to run this query: SELECT * FROM sys.databases WHERE name = 'master The missing resources error message shows up, instead of the correct malformed string error. |
Charles-Gagnon
approved these changes
Jan 27, 2022
nofield
pushed a commit
that referenced
this pull request
Jul 19, 2022
* use old dotnet embedded resource convention flag * fixed positioning * another tab fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to dotnet caused the embedded localization resources file to not be recognized properly.
In order to fix this, for every part of sqltoolsservice that has embedded localization strings, I set the EmbeddedResourceUseDependentUponConvention flag to false to go back to the old behavior pre bump.
See here for the issue: https://docs.microsoft.com/en-us/dotnet/core/compatibility/msbuild
This fixes #1372
and its associated issues:
microsoft/azuredatastudio#17967
microsoft/vscode-mssql#17221