Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Python: fix pre-commit version #10235

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

fix of uv version in pre-commit, fix for redis link

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner January 20, 2025 15:36
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation memory labels Jan 20, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 20, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL16695177889% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
3000 4 💤 0 ❌ 0 🔥 1m 7s ⏱️

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner January 20, 2025 15:40
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jan 20, 2025
@github-actions github-actions bot changed the title Python: fix pre-commit version .Net: Python: fix pre-commit version Jan 20, 2025
Copy link
Contributor

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the connector compatible with Azure Redis? thoughts about adding a note?

@eavanvalkenburg
Copy link
Member Author

this is not a redo of the redis readme (will do that seperately) but a fix for the broken link, the rest is the same.

@eavanvalkenburg eavanvalkenburg merged commit 5b65e6a into microsoft:main Jan 20, 2025
29 checks passed
@eavanvalkenburg eavanvalkenburg deleted the fix_uv branch January 20, 2025 15:46
@dluc
Copy link
Contributor

dluc commented Jan 20, 2025

this is not a redo of the redis readme (will do that seperately) but a fix for the broken link, the rest is the same.

👍 just thought we could use https://learn.microsoft.com/en-us/azure/azure-cache-for-redis/cache-overview-vector-similarity as a link, if it was compatible - maybe something for later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants