Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Implement MongoDB Atlas store #10177

Merged
merged 8 commits into from
Feb 6, 2025

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented Jan 14, 2025

Implement a new version of the MongoDB Atlas Memory Connector with MongoDBAtlasStore and MongoDBAtlasCollection classes.

  • MongoDBAtlasStore:

    • Add python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_store.py to implement the MongoDBAtlasStore class.
    • Add unit tests in python/tests/unit/connectors/memory/mongodb_atlas/test_mongodb_atlas_store.py to test the MongoDBAtlasStore class.
  • MongoDBAtlasCollection:

    • Add python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_collection.py to implement the MongoDBAtlasCollection class.
    • Add unit tests in python/tests/unit/connectors/memory/mongodb_atlas/test_mongodb_atlas_collection.py to test the MongoDBAtlasCollection class.

For more details, open the Copilot Workspace session.

closes #6764

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner January 14, 2025 08:14
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Jan 14, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 14, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/memory/mongodb_atlas
   mongodb_atlas_collection.py1234067%134, 141, 163–165, 171–173, 180, 184, 196–197, 205, 216–244, 251–257, 261, 265, 275–276
   mongodb_atlas_store.py48688%80–81, 129–130, 134–135
   utils.py311068%38–40, 62, 86–88, 106–113
TOTAL17823200089% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3135 4 💤 0 ❌ 0 🔥 1m 35s ⏱️

@eavanvalkenburg eavanvalkenburg force-pushed the eavanvalkenburg/python-mongodb-atlas-store branch from 3dd77d2 to 3aecfbd Compare January 15, 2025 10:21
@eavanvalkenburg eavanvalkenburg force-pushed the eavanvalkenburg/python-mongodb-atlas-store branch from 7854a57 to 56408da Compare January 23, 2025 13:40
eavanvalkenburg and others added 7 commits January 29, 2025 09:14
Implement a new version of the MongoDB Atlas Memory Connector with MongoDBAtlasStore and MongoDBAtlasCollection classes.

* **MongoDBAtlasStore**:
  - Add `python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_store.py` to implement the MongoDBAtlasStore class.
  - Add unit tests in `python/tests/unit/test_mongodb_atlas_store.py` to test the MongoDBAtlasStore class.

* **MongoDBAtlasCollection**:
  - Add `python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_collection.py` to implement the MongoDBAtlasCollection class.
  - Add unit tests in `python/tests/unit/test_mongodb_atlas_collection.py` to test the MongoDBAtlasCollection class.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/semantic-kernel?shareId=XXXX-XXXX-XXXX-XXXX).
@eavanvalkenburg eavanvalkenburg force-pushed the eavanvalkenburg/python-mongodb-atlas-store branch from 56408da to 285a677 Compare January 29, 2025 08:14
@moonbox3 moonbox3 enabled auto-merge February 6, 2025 00:48
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit c445f5c Feb 6, 2025
27 checks passed
@moonbox3 moonbox3 deleted the eavanvalkenburg/python-mongodb-atlas-store branch February 6, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Update MongoDB Atlas Memory Connector to new Vector Search Design
4 participants