FunctionalTests: remove GitCommands tests #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdye may find this PR interesting ;) |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request significantly reduces the cost of Scalar functional tests. It removes all of the tests that are about how Git commands interact in a sparse-checkout environment. Similar tests exist in the upstream Git project and are no longer required to keep
microsoft/gitclean of defects in this area. Removing these tests will save resources and reduce flakiness inmicrosoft/gitpull requests.The functional tests that remain are related to Scalar config, shared object caches, and the GVFS Protocol running against a real Azure DevOps server.
In a second commit, this also removes the functional tests from the CI builds, since they are currently broken. The break is due to the pinned Git version which has not been updated in a while. The correctness of the functional tests is done by running tests from
microsoft/git.