Skip to content

Commit

Permalink
Merge pull request #451: RunVerb: pass git features to ConfigStep
Browse files Browse the repository at this point in the history
The ConfigStep makes a decision about calling 'git maintenance start'
depending on the platform (Linux only for now) and the Git version.
However, the code for computing the feature flags is in ScalarVerb and
needs to be injected by passing it through the ConfigStep constructor.
This was missed in the earlier work that inserted this into other
maintenance steps.

This fixes a feature that should have been introduced in #398.
  • Loading branch information
derrickstolee committed Oct 16, 2020
2 parents 3d83058 + 9293a91 commit 09487ee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Scalar/CommandLine/RunVerb.cs
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ protected override void Execute(ScalarEnlistment enlistment)
switch (this.MaintenanceTask)
{
case ScalarConstants.VerbParameters.Maintenance.AllTasksName:
steps.Add(new ConfigStep(context));
steps.Add(new ConfigStep(context, gitFeatures: gitFeatures));
this.InitializeServerConnection(tracer, enlistment, cacheServerUrl, out objectRequestor, out cacheServer);
gitObjects = new GitObjects(tracer, enlistment, objectRequestor, fileSystem);
steps.Add(new FetchStep(context, gitObjects, requireCacheLock: false, gitFeatures: gitFeatures, forceRun: !this.StartedByService));
Expand Down Expand Up @@ -162,7 +162,7 @@ protected override void Execute(ScalarEnlistment enlistment)

case ScalarConstants.VerbParameters.Maintenance.ConfigTaskName:
this.FailIfBatchSizeSet(tracer);
steps.Add(new ConfigStep(context));
steps.Add(new ConfigStep(context, gitFeatures: gitFeatures));
break;

default:
Expand Down

0 comments on commit 09487ee

Please sign in to comment.