-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate singular SBOM based on manifestInfo parameter #959
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
…andrate_generateSbomBugSpdx3.0
This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:
Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following: Option 1 - Publish this as a breaking change
Option 2 - Refactor the changes to be non-breaking
|
/azp run |
/azp run |
/azp run |
/azp run |
Things are now working correctly when I run the tool with either no
We have no similar warning with SPDX 2.2 |
I tried running with
Compare that to what comes from the validate job:
The error for validate comes from src/Microsoft.Sbom.Api/Config/Validator.cs. Maybe we ought to add a case for the generate parameter? |
This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:
Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following: Option 1 - Publish this as a breaking change
Option 2 - Refactor the changes to be non-breaking
|
We currently generate SBOMs for all support spdx versions. However, we would like the user experience to be only 1 generated SBOM when the generate CLI command is used. For generation the default behavior is to return the SPDX 2.2 SBOM. This is only override if the -mi argument is specified.
For example:
If the -mi parameter is SPDX:3.0, then we will generate SPDX 3.0 SBOMs.
If the -mi parameter is SPDX:2.2, then we will generate SPDX 2.2 SBOMs.
If no -mi parameter specified, then we will generate SPDX 2.2 SBOMs.