Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native-host): handle refactorings in 0.74 #2916

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 11, 2024

Description

Handle refactorings in 0.74

Test plan

In react-native-test-app:

npm run set-react-version 0.74
yarn
cd example
pod install --project-directory=ios
open ios/Example.xcworkspace

# Copy over the changes, then re-run `pod install`
pod install --project-directory=ios

# New Architecture
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=ios
yarn ios
Old Arch New Arch
Simulator Screenshot - iPhone 15 Pro - 2024-01-11 at 14 12 20 Simulator Screenshot - iPhone 15 Pro - 2024-01-11 at 14 08 57

@github-actions github-actions bot added the feature: sdk This is related to 1RN SDK label Jan 11, 2024
@tido64 tido64 merged commit 476ebe8 into main Jan 12, 2024
12 checks passed
@tido64 tido64 deleted the tido/fix-ios-new-arch branch January 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: sdk This is related to 1RN SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants