Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an issue with implicit enum statement capture #103

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

matajoh
Copy link
Member

@matajoh matajoh commented Jan 23, 2024

This PR fixes an issue with enum statement capture, in which an enum could capture its own domain. Also fixed is a parser problem where rule bodies without an assignment operator that were declared on a new line were not correctly joined to their rule heads.

Fixes #101

Signed-off-by: Matthew Johnson <matjoh@microsoft.com>

Verified

This commit was signed with the committer’s verified signature.
matajoh Matthew A Johnson
Signed-off-by: Matthew Johnson <matjoh@microsoft.com>

Verified

This commit was signed with the committer’s verified signature.
matajoh Matthew A Johnson
Signed-off-by: Matthew Johnson <matjoh@microsoft.com>
@matajoh
Copy link
Member Author

matajoh commented Jan 23, 2024

@mjp41 I've added your non-monotone test as a test case, both for the non-standard formatting and the somewhat unexpected binding behaviour.

@matajoh matajoh merged commit 60058a7 into microsoft:main Jan 23, 2024
28 checks passed
@matajoh matajoh deleted the bug-101 branch January 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy not evaluated correctly when statements are not in order within comprehensions
1 participant