Restore NetInfo package changes from #1092 #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The split-out into a standalone module shouldn't block on an incomplete implementation for web
|
LGTM. Feel free to merge if you think it's ready to go. |
|
@sbeca - can you give this a once-over, then I'll merge? |
|
I have a reactxp fork, and I pulled this branch in that fork, rebased it to master and tested it in my app - it seems to work, whereas before with react-native 0.60 + reactxp 1.7.0-rc.1 the app does not work (failing pretty early in bundle startup while looking for the now-deleted RN.NetInfo module) Would love to see this merged even though I know I sound like I'm asking for my free stuff faster ;-). Thank you guys for the work here |
|
Thanks for testing it out! I mostly wanted an additional test beyond the sample app. I'll merge this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split-out into a standalone module shouldn't block on an incomplete implementation for web
Original changes were a collab with @sbeca