-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the WebView component out of core and into an extension #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a first pass, this looks good! Thanks for taking the time to do it. On Friday I'll spend a bit of time testing.
|
berickson1
reviewed
Jun 5, 2019
Validated on Android - fixed one race condition in RXPTest that was causing inaccurate test results. But LGTM |
berickson1
approved these changes
Jun 7, 2019
Review nit has been resolved |
Conflicts with master have now been fixed |
berickson1
pushed a commit
that referenced
this pull request
Sep 12, 2019
This is a follow-on to #1101 - the WebView extension is working fine and the doc exists, it just wasn't linked int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR to #1059 and #1092.
In #1092 it was decided to move
RX.Network
out of the core ReactXP codebase and into an extension, because it would require depending on and linking to an external dependency. #1059 made the WebView depend on an external dependency but kept it in core ReactXP so this PR moves WebView out into an extension.NOTE: While making this move, there were two things that I didn't know how to move that would be good to get feedback on:
WebViewStyle
and everything around that as the creation of styles is tied to some ReactXP internal functions. Seeing asWebViewStyle
is just an extension ofViewStyle
without adding anything extra, I have just removed it for now and just usedViewStyle
. If this is not acceptable, please let me know how I should best include this in the extension.RX.WebViewConstructor
is used for or how best to include it in an extension. Is this needed?