Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Also look for .msix* extensions in CheckIfNeedInstallCertificate #6421

Merged
1 commit merged into from
Nov 4, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 4, 2020

When WindowsTargetPlatformMinVersion is set to >10.0.17134.0, a .msix is output instead of .appx. This causes CheckIfNeedInstallCertificate() to fail since it only looks for .msix.

Microsoft Reviewers: Open in CodeFlow

@dannyvv
Copy link
Member

dannyvv commented Nov 4, 2020

@tido64: Would you mind running yarn change at the root? This will add a change file we use to keep track of properly semantic versioning the various packages in our codebase. 'Patch' would be an appropriate choice for your change.

Copy link
Member

@asklar asklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tido64 the change seems fine to make. I'm curious about the scenario in which it will be needed, can you add some details to the PR description about it? thanks!

…icate

When WindowsTargetPlatformMinVersion is set to >10.0.17134.0, a .msix is
output instead of .appx. This causes CheckIfNeedInstallCertificate() to
fail since it only looks for .msix.
@tido64
Copy link
Member Author

tido64 commented Nov 4, 2020

Would you mind running yarn change at the root? This will add a change file we use to keep track of properly semantic versioning the various packages in our codebase. 'Patch' would be an appropriate choice for your change.

Thanks for the reminder. I always forget this step 😄

the change seems fine to make. I'm curious about the scenario in which it will be needed, can you add some details to the PR description about it? thanks!

Added to description. I'm not sure which version is after 10.0.17134.0 but the Internet seems to agree that as long as WindowsTargetPlatformMinVersion is set to something greater, we'll hit this issue. FWIW, our project is set to 10.0.17763.0.

@dannyvv dannyvv added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Nov 4, 2020
@ghost
Copy link

ghost commented Nov 4, 2020

Hello @dannyvv!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 9bf1f5e into microsoft:master Nov 4, 2020
@tido64 tido64 deleted the patch-1 branch November 4, 2020 21:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants