Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds option for non-ABI TurboModule provider #12383

Closed
wants to merge 4 commits into from
Closed

Adds option for non-ABI TurboModule provider #12383

wants to merge 4 commits into from

Commits on Nov 28, 2023

  1. Adds option for non-ABI TurboModule provider 

    For react-native-windows apps that bypass the JsiAbiApi when
initializing a JS runtime, it would be useful to use the same module
provider infrastructure used for other modules in react-native-windows.

Today the only two options are:
1. Use attributed native modules
2. Use C++ TurboModules wrapped in JsiHostObjectWrappers

This adds a third option:
3. Use C++ TurboModules wrapped in an IJsiNonAbiHostObject

The main reason for creating IJsiNonAbiHostObject and not repurposing
IReactNonAbiValue is that there is already a baked in assumption in the
TurboModule provider that assumes all IReactNonAbiValues are attributed
native modules, so a new interface is needed.
    @rozele
    rozele committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3b6b0ae View commit details
    Browse the repository at this point in the history

  2. Change files

    @rozele
    rozele committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a5b2f65 View commit details
    Browse the repository at this point in the history

  3. Linting and removal of dummy IDL property

    @rozele
    rozele committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7c25cb7 View commit details
    Browse the repository at this point in the history

  4. Improve IDL doc comment

    @rozele
    rozele committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ce29f05 View commit details
    Browse the repository at this point in the history