Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support firing touch and keyboard events for Video when it is full screen #4157

Open
ddalp opened this issue Feb 20, 2020 · 1 comment
Labels
Area: Keyboard enhancement Extensions Tracks issues against community modules and extensions Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone

Comments

@ddalp
Copy link
Contributor

ddalp commented Feb 20, 2020

This issue needs to be sovled in order to support react-native-video community module fully.
Issue is when MPE is in full screen mode, it is moved from its original place in the tree to under FullWindowMediaRoot. Since RNW relies on listening PreviewKeyEvent and TouchEvent on the react root element, it is no longer be able to get the events once MPE is in full window. There are similar issues for Popup and Flyout, we solved it by listening to these events directly on the element. We should do the same for MPE, with a bit more caution that events should be ignored when MPE is not in full screen mode to avoid firing events twice.

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 20, 2020
@ddalp ddalp self-assigned this Feb 20, 2020
@harinikmsft harinikmsft added Extensions Tracks issues against community modules and extensions and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Feb 20, 2020
@harinikmsft harinikmsft added this to the MVP+ (vNext M5) milestone Feb 20, 2020
@ddalp
Copy link
Contributor Author

ddalp commented Mar 13, 2020

Proposal:

  • Add optional parameters to CreatView interface between RNW and native module, hookup pointer and keyboard event listeners to the view instance if flag returns true.
  • Add view object into a global table of ignored objects, and ignore firing keyboard and pointer events for those objects in the global event handler registered on the root object.

@ddalp ddalp removed their assignment Mar 13, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 10, 2020
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Keyboard enhancement Extensions Tracks issues against community modules and extensions Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
None yet
Development

No branches or pull requests

4 participants