Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react-native-video on RNW vNext #2095

Closed
stecrain opened this issue Feb 28, 2019 · 13 comments
Closed

Support react-native-video on RNW vNext #2095

stecrain opened this issue Feb 28, 2019 · 13 comments
Assignees
Labels
Extensions Tracks issues against community modules and extensions must-have p1 Needs: PM Design New feature or request Partner: Education ISV
Milestone

Comments

@stecrain
Copy link
Contributor

@harinikmsft Here's the issue

I want to start experimenting with video support in a React Native Windows project.
To stream play all of the content I'm interested in the video player would need to support mpeg dash and Microsoft smooth streaming.

There is an existing project that adds support for video to the C# React Native Windows implementation. I'm not sure if it makes more sense to update the existing react-native-video to work with RNWCPP or if it should live in this repo. Just wanted to point out that it exists :)

@harinikmsft harinikmsft added the Needs: PM Design New feature or request label Feb 28, 2019
@rozele
Copy link
Collaborator

rozele commented Feb 28, 2019

I would recommend that we fork react-native-video and use this work item as an opportunity to flesh out the native component extensions model.

@ahimberg
Copy link
Member

ahimberg commented Mar 6, 2019

Latest rnwcpp-preview has initial support for adding custom view managers, more work to do things nicely but its possible now.

@stecrain
Copy link
Contributor Author

stecrain commented Mar 6, 2019

Excellent!
So with the latest changes I should be able to just add a custom ViewManager for Video and map it to MediaPlayerElement? (for example)

@ahimberg
Copy link
Member

ahimberg commented Mar 6, 2019

I believe that should be possible but I haven't actually confirmed I can use the custom viewmanager headers/types from outside the repo, we'll be trying that soon in our codebase and fixing up if there are any minor issues. Look at CustomViewManager and replace winrt::checkbox with the xaml control you are wrapping

@harinikmsft harinikmsft added ReadyForDev and removed Needs: PM Design New feature or request Needs: Dev Design labels Mar 6, 2019
@harinikmsft harinikmsft assigned kmelmon and unassigned harinikmsft Mar 6, 2019
@harinikmsft harinikmsft added this to the RNWCPP Preview milestone Mar 11, 2019
@kmelmon kmelmon assigned jonthysell and unassigned kmelmon Mar 18, 2019
@harinikmsft harinikmsft modified the milestones: RNWCPP Preview, RNWCPP v1 Mar 21, 2019
@harinikmsft harinikmsft added the Needs: PM Design New feature or request label Mar 27, 2019
@harinikmsft
Copy link
Contributor

This should cover adding support to a community module

@harinikmsft harinikmsft removed this from the RNWCPP Milestone 2 milestone Apr 25, 2019
@jonthysell
Copy link
Contributor

Removing ready to dev until we have the proper model for native modules.

@chrisglein chrisglein added the Extensions Tracks issues against community modules and extensions label Aug 14, 2019
@chrisglein
Copy link
Member

Moving back to M3 as we'll want to use this as a test case for view managers.

@micahl micahl removed their assignment Sep 11, 2019
@chrisglein
Copy link
Member

Camera has view manager coverage, so this can move to M4.

@chrisglein chrisglein assigned ddalp and unassigned jonthysell Nov 2, 2019
@stmoy stmoy changed the title Video support for RNWCPP Support react-native-video on RNW vNext Nov 11, 2019
@kmelmon
Copy link
Contributor

kmelmon commented Nov 27, 2019

@ddalp do you have a topic branch you can share? I'm looking into the versioning story and would like to see a working viewmanager.

@feechin
Copy link

feechin commented Jan 30, 2020

I am looking to incorporate a video player in my app. So far linking react-native-video still generates an error. Does anyone know how to embed and play a video with the current vnext release? Or point me to a sample react native windows app that has video embedded in it? Thanks.

@ddalp
Copy link
Contributor

ddalp commented Jan 30, 2020

@feechin Our current plan is to release a Video native module soon after MVP release.

@ddalp
Copy link
Contributor

ddalp commented Feb 25, 2020

React-Native-Video community module for windows Cpp/WinRT is now checked in, remaining issue #4157 (keyboard touch events not firing when in full window mode)will be addressed in RNW.

@ddalp ddalp closed this as completed Feb 25, 2020
@chrisglein
Copy link
Member

Providing link to PR to help people looking back over the process of adding Windows support to existing native modules: TheWidlarzGroup/react-native-video#1893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extensions Tracks issues against community modules and extensions must-have p1 Needs: PM Design New feature or request Partner: Education ISV
Projects
None yet
Development

No branches or pull requests