Tests should pass this time!

microsoft · Dec 13, 2019 · b6aedd8 · b6aedd8
1 parent ed5818a
commit b6aedd8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/packages/E2ETest/windows/ReactUWPTestApp/Assets/TreeDump/ImageWithBorder.txt b/packages/E2ETest/windows/ReactUWPTestApp/Assets/TreeDump/ImageWithBorder.txt
@@ -1,5 +1,4 @@
 [Windows.UI.Xaml.Controls.Border]
-    ActualOffset=<0, 0, 0>
     Background=#FFFFFF00
     BorderBrush=#5500FF00
     BorderThickness=10,10,10,10
@@ -14,7 +13,6 @@
     Visibility=Visible
     Width=500
   [react.uwp.ViewPanel]
-      ActualOffset=<10, 10, 0>
       Background=[NULL]
       BorderBrush=#5500FF00
       BorderThickness=10,10,10,10

diff --git a/packages/E2ETest/windows/ReactUWPTestApp/Assets/TreeDump/ImageWithoutBorder0.txt b/packages/E2ETest/windows/ReactUWPTestApp/Assets/TreeDump/ImageWithoutBorder0.txt
@@ -1,5 +1,4 @@
 [react.uwp.ViewPanel]
-    ActualOffset=<0, 0, 0>
     Background=#FFFFFF00
     BorderBrush=#00000000
     BorderThickness=0,0,0,0

diff --git a/packages/E2ETest/windows/ReactUWPTestApp/Assets/TreeDump/ImageWithoutBorder2.txt b/packages/E2ETest/windows/ReactUWPTestApp/Assets/TreeDump/ImageWithoutBorder2.txt
@@ -1,5 +1,4 @@
 [Windows.UI.Xaml.Controls.Border]
-    ActualOffset=<0, 0, 0>
     Background=#FFFFFF00
     BorderBrush=[NULL]
     BorderThickness=0,0,0,0
@@ -14,7 +13,6 @@
     Visibility=Visible
     Width=500
   [react.uwp.ViewPanel]
-      ActualOffset=<0, 0, 0>
       Background=[NULL]
       BorderBrush=#00000000
       BorderThickness=0,0,0,0

diff --git a/packages/E2ETest/windows/TreeDumpLibrary/TreeDumpControlViewManager.cs b/packages/E2ETest/windows/TreeDumpLibrary/TreeDumpControlViewManager.cs
@@ -155,6 +155,11 @@ private async Task MatchDump(string dumpText)
                 {
                     var file = await Windows.ApplicationModel.Package.Current.InstalledLocation.GetFileAsync(@"Assets\TreeDump\" + m_dumpID + ".txt");
                     m_dumpExpectedText = await Windows.Storage.FileIO.ReadTextAsync(file);
+
+                    StorageFolder storageFolder = ApplicationData.Current.LocalFolder;
+                    string copyFileName = "TreeDump\\" + m_dumpID + ".txt";
+                    var copyDumpFile = await storageFolder.CreateFileAsync(copyFileName, CreationCollisionOption.ReplaceExisting);
+                    await Windows.Storage.FileIO.WriteTextAsync(copyDumpFile, m_dumpExpectedText);
                 }
                 catch (IOException)
                 {

diff --git a/packages/E2ETest/windows/TreeDumpLibrary/VisualTreeDumper.cs b/packages/E2ETest/windows/TreeDumpLibrary/VisualTreeDumper.cs
@@ -123,7 +123,7 @@ private static void WalkThroughTree(DependencyObject node, DependencyObject excl
     public sealed class DefaultFilter
     {
         private List<string> _propertyNameWhiteList = new List<string> {"Foreground", "Background", "Padding", "Margin", "RenderSize", "Visibility", "CornerRadius", "BorderThickness",
-            "Width", "Height", "BorderBrush", "VerticalAlignment", "HorizontalAlignment", "Clip", "ActualOffset"};
+            "Width", "Height", "BorderBrush", "VerticalAlignment", "HorizontalAlignment", "Clip", /*"ActualOffset" 19h1*/};
 
         public bool ShouldVisitPropertyValue(string propertyValue)
         {