fix(ReactWebView): Add ReactWebView

ReactWebView provides access to native webview UI components for React Native JavaScript applications. - PR comments #3 implemented Fixes #118
microsoft · May 25, 2016 · 0cd0a51 · 0cd0a51
1 parent 6f358e4
commit 0cd0a51
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/ReactNative/Views/Web/ReactWebViewManager.cs b/ReactNative/Views/Web/ReactWebViewManager.cs
@@ -51,21 +51,21 @@ public override IReadOnlyDictionary<string, object> CommandsMap
         }
 
         /// <summary>
-        /// Sets flag signaling whether JavaScript is enabled.
+        /// Sets whether JavaScript is enabled or not.
         /// </summary>
         /// <param name="view">A webview instance.</param>
-        /// <param name="enabled"></param>
+        /// <param name="enabled">A flag signaling whether JavaScript is enabled.</param>
         [ReactProp("javaScriptEnabled")]
         public void SetJavaScriptEnabled(WebView view, bool enabled)
         {
             view.Settings.IsJavaScriptEnabled = enabled;
         }
 
         /// <summary>
-        /// Sets flag signaling whether Indexed DB is enabled.
+        /// Sets whether Indexed DB is enabled or not.
         /// </summary>
         /// <param name="view">A webview instance.</param>
-        /// <param name="enabled"></param>
+        /// <param name="enabled">A flag signaling whether Indexed DB is enabled.</param>
         [ReactProp("indexedDbEnabled")]
         public void SetIndexedDbEnabled(WebView view, bool enabled)
         {
@@ -76,7 +76,7 @@ public void SetIndexedDbEnabled(WebView view, bool enabled)
         /// Sets the JavaScript to be injected when the webpage loads.
         /// </summary>
         /// <param name="view">A webview instance.</param>
-        /// <param name="injectedJavaScript"></param>
+        /// <param name="injectedJavaScript">An injected JavaScript.</param>
         [ReactProp("injectedJavaScript")]
         public void SetInjectedJavaScript(WebView view, string injectedJavaScript)
         {
@@ -87,7 +87,7 @@ public void SetInjectedJavaScript(WebView view, string injectedJavaScript)
         /// Sets webview source.
         /// </summary>
         /// <param name="view">A webview instance.</param>
-        /// <param name="source"></param>
+        /// <param name="source">A source for the webview (either static html or an uri).</param>
         [ReactProp("source")]
         public void SetSource(WebView view, JObject source)
         {
@@ -137,11 +137,9 @@ public void SetSource(WebView view, JObject source)
                     var headers = source.Value<JObject>("headers");
                     if (headers != null)
                     {
-                        IEnumerator<KeyValuePair<string, JToken>> enumerator = ((JObject)headers).GetEnumerator();
-                        enumerator.Reset();
-                        while (enumerator.MoveNext())
+                        foreach (var header in headers)
                         {
-                            request.Headers.Append(enumerator.Current.Key, enumerator.Current.Value.Value<string>());
+                            request.Headers.Append(header.Key, header.Value.Value<string>());
                         }
                     }
 

diff --git a/js/Components/WebView/WebView.windows.js b/js/Components/WebView/WebView.windows.js
@@ -108,8 +108,7 @@ var WebView = React.createClass({
 
     /**
      * Used on Android and Windows only, JS is enabled by default for WebView on iOS
-     * @platform android
-     * @platform windows
+     * @platform android, windows
      */
     javaScriptEnabled: PropTypes.bool,