Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): restore ability to use NuGet #301

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix(windows): restore ability to use NuGet #301

merged 1 commit into from
Apr 7, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 30, 2021 •
edited
Loading

Description

Restores the ability to use the experimental NuGet packages.

Resolves #299.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

CI should pass.

To test locally, specify the --use-nuget flag when installing the Windows test app:

cd example
yarn
yarn install-windows-test-app --use-nuget
start windows/Example.sln

@tido64 tido64 force-pushed the tido/windows-nuget branch from 9a2a340 to 4db72ef Compare March 30, 2021 23:01
@tido64
Copy link
Member Author

tido64 commented Mar 30, 2021

Looks like there's a significant reduction in build times (template builds don't use NuGet):
image

@tido64 tido64 requested review from kelset and tom-un March 30, 2021 23:25
@tido64 tido64 force-pushed the tido/windows-nuget branch 4 times, most recently from ffa23d9 to e3df02f Compare March 31, 2021 11:50
@tido64 tido64 force-pushed the tido/windows-nuget branch 2 times, most recently from f1e16fe to b3c03b1 Compare March 31, 2021 20:16
@tido64 tido64 added the platform: Windows This affects Windows label Apr 1, 2021
This was referenced Apr 1, 2021
Closed
Merged
JasonVMo
JasonVMo approved these changes Apr 5, 2021
View reviewed changes
Copy link

@JasonVMo JasonVMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool to see the nuget support added. I assume the 1000.0 versions in the solutions get replaced with the version appropriate entries?

@tido64 tido64 force-pushed the tido/windows-nuget branch from b3c03b1 to 40adafe Compare April 6, 2021 07:58
@tido64
Copy link
Member Author

tido64 commented Apr 6, 2021

I assume the 1000.0 versions in the solutions get replaced with the version appropriate entries?

Correct. We used an arbitrary version earlier (63.2). I changed it to 1000.0 to make it easier to replace across all files.

@tido64 tido64 merged commit 1b24a0d into master Apr 7, 2021
@tido64 tido64 deleted the tido/windows-nuget branch April 7, 2021 14:35
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

🎉 This PR is included in version 0.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@JasonVMo JasonVMo JasonVMo approved these changes

@kelset kelset Awaiting requested review from kelset

@tom-un tom-un Awaiting requested review from tom-un

Assignees
No one assigned
Labels
platform: Windows This affects Windows released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Add support for the experimental NuGet feed
2 participants
@tido64 @JasonVMo