Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): make it clear that configure-test-app performs a reset #2262

Merged
merged 8 commits into from
Sep 30, 2024
Merged

fix(config): make it clear that configure-test-app performs a reset #2262

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
93961d4
fix(config): don't overwrite `react-native.config.js` if it may be co…
tido64 Sep 26, 2024
508cfb7
fixup! fix(config): don't overwrite `react-native.config.js` if it ma…
tido64 Sep 26, 2024
234a616
add tests
tido64 Sep 26, 2024
31342bb
Revert "add tests"
tido64 Sep 27, 2024
ec299c2
Revert "fixup! fix(config): don't overwrite `react-native.config.js` …
tido64 Sep 27, 2024
2096f1b
Revert "fix(config): don't overwrite `react-native.config.js` if it m…
tido64 Sep 27, 2024
a861e87
better message
tido64 Sep 27, 2024
66701b2
change wording to include templates
tido64 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/configure.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,8 @@ export function isDestructive(packagePath, { files, oldFiles }, fs = nodefs) {

if (modified.length > 0 || removed.length > 0) {
if (modified.length > 0) {
warn("The following files will be overwritten:");
const reset = colors.bold("reset");
warn(`The following files will be ${reset} to their original state:`);
modified.sort().forEach((file) => warn(file, " "));
}
if (removed.length > 0) {
Expand Down Expand Up @@ -657,10 +658,11 @@ export function configure(params, fs = nodefs) {
const config = gatherConfig(params);

if (!force && isDestructive(packagePath, config)) {
error("Destructive file operations are required.");
console.log(
`Re-run with ${colors.bold("--force")} if you're fine with this.`
error(
"Some files will be reset and/or removed: You may have to manually restore your own or your template's customizations to get the app working again (for more details, see https://github.com/microsoft/react-native-test-app/wiki/Updating#reconfiguringresetting-rnta)"
);
const forceFlag = colors.bold("--force");
console.log(`Re-run with ${forceFlag} if you're fine with this.`);
return 1;
}

Expand Down
Loading