Enclose the app path in quotes, so that the open command doesn't split it if it contains spaces

[sergi]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

When running npx react-native run-macos (or locally node node_modules/react-native-macos/local-cli/cli.js run-macos) and if the target app has spaces in the name, the current call to the open macOS command will split the path and only keep the last part as the name in the app, which will fail:

...
▸ Build Succeeded
info Launching app "io.sergi.todolist" from "/Users/sergi/Library/Developer/Xcode/DerivedData/Todo_List-efowxgkzzzbxtgeghbplezporgmk/Build/Products/Debug/Todo List.app"
error Failed to launch the app, The file /Users/sergi/code/todo_list/macos/List.app does not exist.

This fix surrounds the path in quotes, which is the standard way to deal with spaces in the path. It solves the issue and introduces no other effects.

Changelog

[macOS] [Fixed] - Fixes CLI failing to launch app if the path contains spaces

Test Plan

This fix requires no further testing, as it only encloses a file path in quotes, keeping the exact same previous functionality, and preventing spaces from making open command misbehave.

Microsoft Reviewers: Open in CodeFlow

[alloy]

Thanks! 🙏

Perhaps even better would have been if we were to use execFile here, i.e. not spawn a shell at all, but this is a good iterative fix on its own 👍

PS: If you’d like to see this in a v0.63.x stable release, it would be great if you could send the same PR to the 0.63-stable branch.

[ghost]

All CLA requirements met.

[alloy]

Btw, be sure to sign the CLA.

[sergi]

Signed, thanks!

[sergi]

@alloy I see a homebrew-related fix has been commited to this PR. Is it related?

[alloy]

Nope, that was to fix an earlier CI failure. I think this failure is a flunk, so I’m re-running the failed task.