Xcode12 beta4 compiler fixes #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-un
approved these changes
Aug 8, 2020
| @@ -16,6 +16,11 @@ | |||
| #import "RCTModuleData.h" | |||
| #import "RCTProfile.h" | |||
|
|
|||
| #if TARGET_OS_OSX // TODO(macOS, https://github.com/microsoft/react-native-macos/issues/533) | |||
| // To compile in Xcode 12 beta 4 on macOS, we need to explicitly pull in the framework to get the definition for CACurrentMediaTime() | |||
| #import <Quartz/Quartz.h> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This is needed to compile on Xcode12 beta 4. Previously we were successfully compiling on beta 2, but as things change between the betas this broke.
The compiler error is that it can't find the definition to a c++ function used for internal performance tracking/logging. We can explicitly include that framework (quartz) for macOS.
Created an OSS issue in this repo to track changes needed for the transition to Xcode 12 via issue #533 .
Changelog
[macOS] [Fixed] - Fix Xcode 12 beta 4 compiler error that we're missing a definition
Test Plan
If it compiles on macOS then it's fixed and shouldn't break anything. Built for iOS/macOS locally on Xcode 12 beta 4. CI will test again on Xcode 11 and soon on Xcode 12 beta 4.
Microsoft Reviewers: Open in CodeFlow