Fix crash in NSLayoutManager during autorelease dealloc #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew." This reverts commit 5a67ae0.
|
Libraries/Text/Text/RCTTextView.m
Outdated
| // associated NSLayoutManager dealloc later in an autorelease pool. | ||
| // Manually removing the layout managers from _textStorage prior to release | ||
| // works around this issue in AppKit. | ||
| NSArray<NSLayoutManager *> *managers = [_textStorage layoutManagers]; |
There was a problem hiding this comment.
Can we confirm this makes a copy so we don't crash on mutating a collection while iterating it? If not we should explicitly copy the result of [_textStorage layoutManagers]
There was a problem hiding this comment.
Its a good call to copy it. In practice there's only ever a single object in the array but that could change.
HeyImChris
approved these changes
Jul 28, 2020
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 23, 2022
Summary: In a prior diff we removed some code that fixed an occasional crash in RCTTextView. This diff brings back the code, adapted from microsoft#523. Test Plan: Open the Text section of RNTester several times and verify no crash: |Before|After| |{F612971452}|{F612971479}| Reviewers: skyle Reviewed By: skyle Subscribers: eliwhite Differential Revision: https://phabricator.intern.facebook.com/D28166631 Tasks: T78743077 Signature: 28166631:1620086528:d359ab6e0c3477f2e52784534b6763156b33b1e5
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 30, 2022
Summary: In a prior diff we removed some code that fixed an occasional crash in RCTTextView. This diff brings back the code, adapted from microsoft#523. Test Plan: Open the Text section of RNTester several times and verify no crash: |Before|After| |{F612971452}|{F612971479}| Reviewers: skyle Reviewed By: skyle Subscribers: eliwhite Differential Revision: https://phabricator.intern.facebook.com/D28166631 Tasks: T78743077 Signature: 28166631:1620086528:d359ab6e0c3477f2e52784534b6763156b33b1e5
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 5, 2022
Summary: In a prior diff we removed some code that fixed an occasional crash in RCTTextView. This diff brings back the code, adapted from microsoft#523. Test Plan: Open the Text section of RNTester several times and verify no crash: |Before|After| |{F612971452}|{F612971479}| Reviewers: skyle Reviewed By: skyle Subscribers: eliwhite Differential Revision: https://phabricator.intern.facebook.com/D28166631 Tasks: T78743077 Signature: 28166631:1620086528:d359ab6e0c3477f2e52784534b6763156b33b1e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The RCTTextView has an NSTextStorage ivar. When these objects are released and dealloced in an autorelease pool, sometimes there can be an exception thrown in system code as
NSLayoutManager dealloccalls its own_NSRemoveDirtyLayoutManagermethod which fails on a call to-[NSConcretePointerArray removePointerAtIndex:].We used to hit this issue consistently when resizing a window that contained many runs of text. The workaround was to manually remove all layout managers from the
_textStorageivar just prior to replacing it with another NSTextStorage.Even with this fix, the
[RNTesterSnapshotTests testTextExample]test would still occasionally crash with the same callstack, and now @ospfranco reported the crash in a dependent project. Doing the same operation of manually removing all the layout managers from the text storage in RCTTextView dealloc seems to fix the issue. #357Changelog
[fixed] [macOS] - Fix crash in NSLayoutManager during autorelease dealloc
Test Plan
Re-enabled the previously disabled
[RNTesterSnapshotTests testTextExample]test. @ospfranco manually tested the change.Microsoft Reviewers: Open in CodeFlow