Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ActivityIndicator with custom color causing brief flicker #446

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix ActivityIndicator with custom color causing brief flicker #446

merged 1 commit into from
Jun 17, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 11, 2020 •
edited by ghost
Loading

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

The window flickers when rendering a view with an ActivityIndicator and a custom colour. This is caused by setting -[NSView setContentFilters:].

Resolves #412

Changelog

[macOS] [Fixed] - Fix ActivityIndicator with custom color causing brief flicker

Test Plan

indicator-flicker

Microsoft Reviewers: Open in CodeFlow

@tido64 tido64 requested a review from tom-un as a code owner June 11, 2020 12:43
@tido64 tido64 force-pushed the fix-activity-indicator-flicker branch from 96f848f to b04f477 Compare June 12, 2020 10:13
@tom-un tom-un merged commit 06db930 into microsoft:master Jun 17, 2020
@tido64 tido64 deleted the fix-activity-indicator-flicker branch June 17, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrajeswaran anandrajeswaran anandrajeswaran left review comments

@tom-un tom-un tom-un approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActivityIndicator causes brief flicker
3 participants
@tido64 @tom-un @anandrajeswaran