Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow:'hidden' github issue #399 #419

Closed
wants to merge 1 commit into from
Closed

Fix overflow:'hidden' github issue #399 #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions React/Views/RCTView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,13 @@ - (void)reactSetFrame:(CGRect)frame
}
}

#if TARGET_OS_OSX // [TODO(macOS https://github.com/microsoft/react-native-macos/issues/399)
- (void)setClipsToBounds:(BOOL)clipsToBounds {
[super setClipsToBounds:clipsToBounds];
self.layer.masksToBounds = clipsToBounds;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is explicitly documented as undefined behavior. See https://developer.apple.com/library/archive/releasenotes/AppKit/RN-AppKit/#10_13Layer-backed%20Views.
macOS 10.13 is more consistent around updates to properties of views' layers (that is, layers that are the .layer of some NSView, however created). As before, if an application modifies such a layer by changing any of the following properties, the behavior of the application is undefined: bounds, position, zPosition, anchorPoint, anchorPointZ, transform, affineTransform, frame, hidden, geometryFlipped, masksToBounds, opaque, compositingFilter, filters, shadowColor, shadowOpacity, shadowOffset, shadowRadius, shadowPath, layoutManager.
I'm not super clear on what the overflow:'hidden' behavior is supposed to do and why it's valuable, but we need to come up with another approach

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could set the view's layer to a custom layer. I tried the following locally and it seemed to work:

in RCTView.m I created a

@interface RCTNoClippingLayer: CALayer
@end
@implementation RCTNoClippingLayer
-(BOOL) masksToBounds {
  return NO;
}
@end

and then added a setClipsToBounds: override that does

- (void)setClipsToBounds:(BOOL)clipsToBounds {
  [super setClipsToBounds:clipsToBounds];
  if (clipsToBounds) {
    self.layer = [RCTNoClippingLayer new];
  }
}

In RNTester it works. The impl is probably too simple though. I guess we'd have to cache the original CALayer and restore it if the prop is set to NO. And the impl should probably be put up a level on RCTUIView since that's where clipsToBounds is defined. But I think in principal it avoids the undefined behavior as documented by Apple of setting props on existing layers.

}
#endif

- (void)displayLayer:(CALayer *)layer
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to set masksToBounds in this function?

{
if (CGSizeEqualToSize(layer.bounds.size, CGSizeZero)) {
Expand Down