Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postInstall step to restore the executable bit on scripts. #244

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

tom-un
Copy link
Collaborator

@tom-un tom-un commented Jan 30, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

The react-native-macos npm publish step is performed on a Windows Azure DevOps agent. Windows file systems don't have an executable bit, so the npm package doesn't contain the executable bit on bash scripts.

Long term we will change the build pipeline to use a Mac or Linux build agent. But in the near term the build pipeline still has some other Windows dependencies so for now we will use an npm postinstall script to restore the executable bit on scripts.

Microsoft Reviewers: Open in CodeFlow

@tom-un tom-un merged commit fd8f8d7 into master Jan 30, 2020
@acoates-ms acoates-ms deleted the tomun/postInstall branch April 22, 2020 17:48
@Saadnajmi Saadnajmi mentioned this pull request Jan 9, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant