Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.71][Cherry Pick] Only apply isHighlighted native prop on iOS #1893

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[0.71][Cherry Pick] Only apply isHighlighted native prop on iOS #1893

merged 1 commit into from
Jul 28, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Backport of #1892 to 0.71-stable

@rozele @Saadnajmi
Only apply isHighlighted native prop on iOS (facebook#38642)
fac0503 
Summary:
Pull Request resolved: facebook#38642

isHighlighted is only used for iOS. Even macOS disables it (see microsoft#1346).

This change ensures that the isHighlighted prop is only updated for iOS.

## Changelog:

[General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only `isHighlighted` prop to iOS

Reviewed By: lenaic, sammy-SC

Differential Revision: D47800845

fbshipit-source-id: af109be17027b2fbc9408e2ec9e1b841c709fe35
@Saadnajmi Saadnajmi requested a review from a team as a code owner July 28, 2023 17:36
@Saadnajmi Saadnajmi changed the base branch from main to 0.71-stable July 28, 2023 17:36
@github-actions
Copy link

Fails
🚫

❔ This pull request needs a description.
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against fac0503

@Saadnajmi Saadnajmi merged commit d40303c into microsoft:0.71-stable Jul 28, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amgleitman amgleitman amgleitman approved these changes

Assignees
No one assigned
Labels
Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saadnajmi @amgleitman @rozele