Skip to content

Commit

Permalink
Fix some test stuff
Browse files Browse the repository at this point in the history
Summary: missing header and platform. attributedstring builds now, but still fails because of T34990592

Reviewed By: mdvacca

Differential Revision: D10349210

fbshipit-source-id: dcd163df9ac9a4fcb36399cb9f93dbf1b33c062d
  • Loading branch information
sahrens authored and facebook-github-bot committed Oct 12, 2018
1 parent 1ebc845 commit 122eba5
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion ReactCommon/fabric/core/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = APPLE,
platforms = (ANDROID,APPLE),
deps = [
"xplat//folly:molly",
"xplat//third-party/gmock:gtest",
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/debug/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = APPLE,
platforms = (ANDROID, APPLE),
deps = [
"xplat//folly:molly",
"xplat//third-party/gmock:gtest",
Expand Down
1 change: 1 addition & 0 deletions ReactCommon/fabric/debug/DebugStringConvertible.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#pragma once

#include <climits>
#include <memory>
#include <string>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/events/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = APPLE,
platforms = (ANDROID,APPLE),
deps = [
"xplat//folly:molly",
"xplat//third-party/gmock:gtest",
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/graphics/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = APPLE,
platforms = (ANDROID,APPLE),
deps = [
"xplat//folly:molly",
"xplat//third-party/gmock:gtest",
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/imagemanager/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = APPLE,
platforms = (ANDROID, APPLE),
deps = [
"xplat//folly:molly",
"xplat//third-party/gmock:gtest",
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/uimanager/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = APPLE,
platforms = (ANDROID, APPLE),
deps = [
"xplat//folly:molly",
"xplat//third-party/gmock:gtest",
Expand Down

0 comments on commit 122eba5

Please sign in to comment.