Skip to content

Commit

Permalink
Remove TextInput setting insertionPointColor (#1321)
Browse files Browse the repository at this point in the history
  • Loading branch information
christophpurrer authored Aug 5, 2022
1 parent e960741 commit 0f665ba
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions Libraries/Text/TextInput/Multiline/RCTUITextView.m
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ - (instancetype)initWithFrame:(CGRect)frame
_placeholderView.numberOfLines = 0;
[self addSubview:_placeholderView];
#else // [TODO(macOS GH#774)
self.insertionPointColor = [NSColor selectedControlColor];
// Fix blurry text on non-retina displays.
self.canDrawSubviewsIntoLayer = YES;
self.allowsUndo = YES;
Expand Down Expand Up @@ -131,7 +130,7 @@ - (void)setSelectionColor:(RCTUIColor *)selectionColor
NSMutableDictionary *selectTextAttributes = self.selectedTextAttributes.mutableCopy;
selectTextAttributes[NSBackgroundColorAttributeName] = selectionColor ?: [NSColor selectedControlColor];
self.selectedTextAttributes = selectTextAttributes.copy;
self.insertionPointColor = self.selectionColor ?: [NSColor selectedControlColor];
self.insertionPointColor = self.selectionColor ?: [NSColor textColor];
}

- (RCTUIColor*)selectionColor
Expand Down
1 change: 0 additions & 1 deletion Libraries/Text/TextInput/Singleline/RCTUITextField.m
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ - (NSText *)setUpFieldEditorAttributes:(NSText *)textObj
NSMutableDictionary *selectTextAttributes = fieldEditor.selectedTextAttributes.mutableCopy;
selectTextAttributes[NSBackgroundColorAttributeName] = self.selectionColor ?: [NSColor selectedControlColor];
fieldEditor.selectedTextAttributes = selectTextAttributes;
fieldEditor.insertionPointColor = self.selectionColor ?: [RCTUIColor selectedControlColor];
return fieldEditor;
}

Expand Down

0 comments on commit 0f665ba

Please sign in to comment.