fix: fix codepush.gradle trying to access non-existent directories #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
approved these changes
Nov 8, 2022
|
Will this ever be merged? |
|
can anyone merge this or tell us why it is not a good idea and close it? |
lucen-ms
previously approved these changes
Nov 8, 2023
|
@AmyrAhmady thanks for the contribution! Can you please resolve conflicts? I want to merge this afterwards. |
|
@velimir-jankovic Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes common android issue when there's no directory such as
android/app/build/generated/res/react/release, eitherreleasedirectory or its parentreactThere have been multiple issues pointing to this but for some reason no one created a PR for it
this workaround or fix is taken from this comment:
#1578 (comment)
Some of the related issues:
#1977
#1578
#1866
#1812
#1977