Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] Fix imports for Cocoapods + Swift projects + use_frameworks! #2004

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

liamxujia
Copy link
Contributor

This PR fixes an error we encountered in a hybrid (Swift + React Native) app we’re developing, and use_frameworks! flag.
SSZipArchive was introduced as a module unlike JWT, SSZipArchive imports should be added with a namespace, I guess all projects introduced through use_frameworks! will have this problem.

Looking forward to repair. Thank you.

@liamxujia
Copy link
Contributor Author

企业微信截图_e5a57338-0a4d-4780-9fc1-cdba16446e39
企业微信截图_bb3ffe8a-85dc-48ae-9c22-8674ed713542

@velimir-jankovic velimir-jankovic requested a review from a team as a code owner November 8, 2023 15:07
@velimir-jankovic velimir-jankovic merged commit 2b37595 into microsoft:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants