Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] 7.0.2 Image asset not working after apply new codepush release #2138

Closed
KoreanThinker opened this issue Sep 7, 2021 · 30 comments
Closed
Labels

Comments

@KoreanThinker
Copy link

KoreanThinker commented Sep 7, 2021

Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):

Steps to Reproduce

  1. Release build to android physical device
  2. change some file
  3. run codepush release
  4. reopen app (until applied codepush)

Expected Behavior

Right after the release build
KakaoTalk_Photo_2021-09-08-00-33-12 001

Actual Behavior

after reopened the app (when applied codepush)
KakaoTalk_Photo_2021-09-08-00-33-12 002

Environment

  • react-native-code-push version: 7.0.2
  • react-native version: 0.65.1
  • iOS/Android/Windows version: Android 11
  • Does this reproduce on a debug build or release build: release
  • Does this reproduce on a simulator, or only on a physical device: I tested only physical, I don't know about simulator

(The more info the faster we will be able to address it!)

@KoreanThinker KoreanThinker changed the title [Android] Image not working [Android] 7.0.2 Image asset not working after apply new codepush release Sep 7, 2021
@KoreanThinker
Copy link
Author

Additionally I disabled hermes

@blueberry6401
Copy link

I though this is an issue with RN 0.65.1. Codepush works fine for me before upgrading to newer version of RN.

@dkahdwk
Copy link

dkahdwk commented Sep 11, 2021

I'm in the same situation...Did you find a solution?

@KoreanThinker
Copy link
Author

KoreanThinker commented Sep 11, 2021

I'm in the same situation...Did you find a solution?

The best way is enable hermes. But this solution not working on seconed codepush update. It's work on first codepush update. I'm waiting 7.0.3

@dkahdwk
Copy link

dkahdwk commented Sep 11, 2021

저도 같은 상황인데...해결책은 찾으셨나요?

가장 좋은 방법은 enable hermes입니다. 그러나이 솔루션은 두 번째 코드 푸시 업데이트에서 작동하지 않습니다. 첫 번째 코드 푸시 업데이트 작업입니다. 7.0.3을 기다리고 있습니다

Thank you for your answer! I'll have to wait for 7.0.3.

@KoreanThinker
Copy link
Author

KoreanThinker commented Sep 11, 2021

저도 같은 상황인데...해결책은 찾으셨나요?

가장 좋은 방법은 enable hermes입니다. 그러나이 솔루션은 두 번째 코드 푸시 업데이트에서 작동하지 않습니다. 첫 번째 코드 푸시 업데이트 작업입니다. 7.0.3을 기다리고 있습니다

Thank you for your answer! I'll have to wait for 7.0.3.

If you must not require RN 0.65. You can solve to downgrading RN 0.64.2 & codepush 6.2+

@apexglory
Copy link

apexglory commented Sep 13, 2021

I have the same issue, images show in first codepush update but disappear on second, when i downgrading RN to 0.64.2 and specify react-native-code-push version to 7.0.1, it proper functioning!
You still need to enableHermes in android/app/build.gradle!

project.ext.react = [
    enableHermes: false
]

@Andriiklymiuk
Copy link

has anyone tried to make it work with 0.65.1 ?

@Andriiklymiuk
Copy link

Try to downgrade to 7.0.1, no need to downgrade react native from 0.65.1
#2136 (comment)

@blueberry6401
Copy link

Confirmed, downgrade to 7.0.1 and still works with 0.65.1
By the way, did code-push team test before releasing?

@mcAnastasiou
Copy link

Same issue here

@KoreanThinker
Copy link
Author

Same issue here

#2138 (comment) It's work for me

@mcAnastasiou
Copy link

I tried to downgrade and it still doesn't work. The second update always removes the images

@mcAnastasiou
Copy link

I downgraded to ^6.4.1 in order to work

@ChrisWiles
Copy link

I just updated to 7.0.3, and spent like 8 hours trying to figure out why android lost images on 2nd+ codepush
Installing 7.0.1 fixes the issue... 😢

 "dependencies": {
    "@fortawesome/fontawesome-svg-core": "1.2.30",
    "@fortawesome/free-brands-svg-icons": "5.14.0",
    "@fortawesome/free-regular-svg-icons": "5.14.0",
    "@fortawesome/free-solid-svg-icons": "5.14.0",
    "@fortawesome/react-native-fontawesome": "0.2.5",
    "@react-native-community/art": "1.0.2",
    "@react-native-community/async-storage": "1.6.2",
    "@react-native-community/blur": "3.4.1",
    "@react-native-community/netinfo": "4.6.0",
    "@react-native-community/push-notification-ios": "1.0.3",
    "@reduxjs/toolkit": "1.6.1",
    "@sentry/react-native": "2.6.2",
    "appcenter": "2.5.0",
    "appcenter-analytics": "2.5.0",
    "appcenter-crashes": "2.5.0",
    "color": "3.1.2",
    "cookie": "0.4.1",
    "cookieparser": "0.1.0",
    "currency-formatter": "1.5.8",
    "formik": "2.2.6",
    "geolib": "3.3.1",
    "lodash": "4.17.21",
    "moment": "2.29.1",
    "moment-timezone": "0.5.33",
    "native-base": "2.15.2",
    "password-validator": "5.1.1",
    "path": "0.12.7",
    "phone": "2.4.21",
    "prop-types": "15.7.2",
    "pubnub": "4.32.0",
    "re-reselect": "4.0.0",
    "react": "16.13.1",
    "react-native": "0.61.5",
    "react-native-app-link": "1.0.0",
    "react-native-auto-height-image": "1.1.3",
    "react-native-background-fetch": "4.0.3",
    "react-native-background-geolocation": "4.3.0",
    "react-native-camera": "3.9.0",
    "react-native-code-push": "7.0.1",
    "react-native-device-info": "5.3.0",
    "react-native-elements": "1.2.7",
    "react-native-fast-image": "7.0.2",
    "react-native-fs": "2.16.2",
    "react-native-gesture-handler": "1.5.0",
    "react-native-image-picker": "1.1.0",
    "react-native-image-resizer": "1.1.0",
    "react-native-maps": "0.29.3",
    "react-native-maps-directions": "1.7.6",
    "react-native-masked-text": "1.13.0",
    "react-native-modal": "11.5.3",
    "react-native-orientation-locker": "1.1.7",
    "react-native-paper": "4.7.2",
    "react-native-parallax-scroll-view": "0.21.3",
    "react-native-permissions": "2.2.2",
    "react-native-progress": "4.0.1",
    "react-native-push-notification": "3.1.9",
    "react-native-reanimated": "1.4.0",
    "react-native-signature-capture": "0.4.10",
    "react-native-sound": "0.11.0",
    "react-native-svg": "9.13.6",
    "react-native-svg-uri": "1.2.3",
    "react-native-vector-icons": "6.6.0",
    "react-native-webview": "7.5.1",
    "react-navigation": "4.0.10",
    "react-navigation-drawer": "2.3.3",
    "react-navigation-header-buttons": "3.0.4",
    "react-navigation-stack": "1.10.3",
    "react-navigation-tabs": "2.5.6",
    "react-redux": "7.2.1",
    "reanimated-bottom-sheet": "1.0.0-alpha.18",
    "recompose": "0.30.0",
    "redux": "4.0.5",
    "redux-persist": "5.10.0",
    "redux-saga": "1.1.3",
    "reselect": "4.0.0",
    "styled-components": "5.3.0",
    "superagent": "5.1.0",
    "url": "0.11.0",
    "validator": "13.6.0",
    "yup": "0.32.9"
  },

@jakecurreri
Copy link

This is an active issue for 7.0.3. Our production app for Android is not showing any bundled images after upgrading.

@ghost
Copy link

ghost commented Oct 7, 2021

Does anything update these issues? How to resolve this issue?

@fbartho
Copy link

fbartho commented Oct 8, 2021

We're experiencing this issue as well, but this is our first time working with CodePush, so we thought it was a configuration error on our side.

@knro
Copy link

knro commented Oct 11, 2021

Have to downgrade to get this fixed. This is a critical issue.

@alexandergoncharov-zz
Copy link
Contributor

Hi there :)
We merged and published this PR: #2149

Could you please try to reproduce your issue with a new version and let us know if it was successful or not?

@dungtran3864
Copy link

dungtran3864 commented Oct 17, 2021

I'm using CodePush version 7.0.1 and RN version 0.63.3. I always lost the images after the 2nd CodePush deploy on Android devices. Could anyone suggest what should I do? Should I downgrade to CodePush version 6?

UPDATE: Microsoft releases CodePush v.7.0.4 that specifically fixes the images not loading on Android issue. I have updated CodePush to this version and I no longer have this issue anymore.

@seobaeksol
Copy link

I updated CodePush to v7.0.4 but still happen.
Actually there was no problem before i change my assets to lower size. I only changed some images and then i got this issue.
When i change some images, they are shown properly. But at the next push, the images disappear...

@evelant
Copy link

evelant commented Oct 26, 2021

This still happens on 7.0.4, images disappear when a 2nd push is applied

@knro
Copy link

knro commented Oct 29, 2021

I can confirm the same issue is still happening for 7.0.4

@ianitararache
Copy link

ianitararache commented Nov 1, 2021

Same here, updated to 7.0.4 and the problem is still there

LE: It works, my bad. What I did wrong was just updating CodePush package and releasing two updates targeting a version which was built with an older CodePush version.
Correct way was to build a new Android version with CodePush 7.0.4 and afterwards target it and release multiple updates.
Second update displays the images. Thanks for the update!

@jakecurreri
Copy link

Confirmed resolved in 7.0.4 👍 Second update is displaying images.

@knro try a full release with a new versionName for Android. Otherwise, the package will default to the build that references the older CodePush version.

@knro
Copy link

knro commented Nov 8, 2021

@jcxswc This was with a new binary version. I trusted this would work well then I got hammered with bug reports on missing icons again in the updated binary release.

@jakecurreri
Copy link

Interesting. Do you have Hermes enabled in the build @knro?

@knro
Copy link

knro commented Nov 8, 2021

Correct, I do.

@ghost ghost added the stale label Jan 8, 2022
@ghost
Copy link

ghost commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests