Skip to content

Commit

Permalink
[android] RN0.43 capacity (#735)
Browse files Browse the repository at this point in the history 
Fixed android project build issues that have place due to the following breaking changes: 
facebook/react-native#12329
facebook/react-native#12396
  • Loading branch information
@nihgwu @sergey-akhalkov
nihgwu authored and sergey-akhalkov committed Mar 23, 2017
1 parent 360033e commit 300a835
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.modules.core.DeviceEventManagerModule;
import com.facebook.react.uimanager.ReactChoreographer;
import com.facebook.react.modules.core.ChoreographerCompat;
import com.facebook.react.modules.core.ReactChoreographer;

import org.json.JSONArray;
import org.json.JSONException;
Expand Down Expand Up @@ -254,7 +255,7 @@ public void call(DownloadProgress downloadProgress) {
getReactApplicationContext().runOnUiQueueThread(new Runnable() {
@Override
public void run() {
ReactChoreographer.getInstance().postFrameCallback(ReactChoreographer.CallbackType.TIMERS_EVENTS, new Choreographer.FrameCallback() {
ReactChoreographer.getInstance().postFrameCallback(ReactChoreographer.CallbackType.TIMERS_EVENTS, new ChoreographerCompat.FrameCallback() {
@Override
public void doFrame(long frameTimeNanos) {
if (!latestDownloadProgress.isCompleted()) {
Expand Down

4 comments on commit 300a835

@f0rr0
Copy link

@f0rr0 f0rr0 commented on 300a835 Apr 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-akhalkov any idea on when this would be released?

@sergey-akhalkov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f0rr0, we will publish this on npm the same day that RN 0.43 exits RC.

@richardhuaaa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f0rr0 this should now be in react-native-code-push@2.0.1-beta :)

@f0rr0
Copy link

@f0rr0 f0rr0 commented on 300a835 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Silhouettes just upgraded works fine thanks!

Please sign in to comment.