Unify file access in debugger #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idavis
force-pushed
the
iadavis/file-resolution
branch
from
6e72294 to
7050fc1
Compare
billti
reviewed
Aug 15, 2023
billti
reviewed
Aug 15, 2023
idavis
force-pushed
the
iadavis/file-resolution
branch
from
7050fc1 to
28d0f37
Compare
swernli
approved these changes
Aug 16, 2023
billti
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for windows which doesn't play well with URIs. The DAP
setDebuggerPathFormat/convertClientPathToDebugger/convertDebuggerPathToClientcan't be used as there is a bug requiring nodejs which prevents usage in web extensions. Once the bug is fixed we can update the debugger to use URIs without this PR's retry conversion.This PR also fixes an issue where if the user closed the file being debugged or it was open as 'temporarily open' then we couldn't step back into the code.