Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform superposition preparation moved to std #2195

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Uniform superposition preparation moved to std #2195

merged 5 commits into from
Feb 21, 2025

Conversation

DmitryVasilevsky
Copy link
Contributor

@DmitryVasilevsky DmitryVasilevsky commented Feb 20, 2025 •
edited
Loading

Moved uniform superposition preparation into Std.StatePreparaion (simplified version based on df chemistry)
Improved checks and updated doc comments
Added tests

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 3c64b22

Test This Branch On Main Difference
compile core + standard lib 20612429 bytes 19574269 bytes 1038160 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 7c02bca

Test This Branch On Main Difference
compile core + standard lib 20612429 bytes 19574269 bytes 1038160 bytes

@DmitryVasilevsky DmitryVasilevsky marked this pull request as draft February 20, 2025 22:33
@DmitryVasilevsky DmitryVasilevsky marked this pull request as ready for review February 21, 2025 00:13
@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 9ad33fd

Test This Branch On Main Difference
compile core + standard lib 19866837 bytes 19574269 bytes 292568 bytes

swernli
swernli approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how much code this change gets out of the samples and libraries and into a more compact stdlib operation, thanks!

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for e88d381

Test This Branch On Main Difference
compile core + standard lib 19841233 bytes 19574269 bytes 266964 bytes

@DmitryVasilevsky DmitryVasilevsky added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 201f456 Feb 21, 2025
18 checks passed
@DmitryVasilevsky DmitryVasilevsky deleted the dmitryv/chem_lib_updates branch February 21, 2025 19:23
@DmitryVasilevsky DmitryVasilevsky mentioned this pull request Feb 21, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@orpuente-MS orpuente-MS orpuente-MS approved these changes

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

@msoeken msoeken Awaiting requested review from msoeken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitryVasilevsky @swernli @orpuente-MS