Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix position access error #1267

Merged
merged 2 commits into from
Nov 8, 2022
Merged

fix position access error #1267

merged 2 commits into from
Nov 8, 2022

Conversation

lerit
Copy link
Contributor

@lerit lerit commented Aug 25, 2022 •
edited
Loading

position is a subproperty of _value,cash and now_account_value belongs to _value.position
maybe error since:#1120

@lerit
fix position access error
ac2192b 
position is s sub attribute of _value
error since commit(id:89972f6c6f9fa629b4f74093d4ba1e93c9f7a5e5)
@you-n-g
Copy link
Collaborator

you-n-g commented Aug 29, 2022

Thanks for your contributions!

Please fix the CI error.

@you-n-g you-n-g requested a review from SunsetWolf August 29, 2022 09:59
@you-n-g
Copy link
Collaborator

you-n-g commented Aug 29, 2022 •
edited
Loading

Thanks for your contribution.
This reflex another flaw of our CI that it can't detect the errors in the report.
So I think it would be better to add such a check in our CI. (It may be some command like jupyter nbconvert workflow_by_code.ipynb)

Would you like to contribute to this feature in this PR?

Otherwise, @SunsetWolf will help with this feature.

@lerit
Copy link
Contributor Author

lerit commented Aug 30, 2022

I have fix the CI error.
@you-n-g

@you-n-g you-n-g mentioned this pull request Sep 2, 2022
Open
@you-n-g you-n-g merged commit 59fbf23 into microsoft:main Nov 8, 2022
@you-n-g
Copy link
Collaborator

you-n-g commented Nov 8, 2022 •
edited
Loading

It looks great.
Thanks for your contribution.

@you-n-g you-n-g added the bug Something isn't working label Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@lerit
fix position access error (microsoft#1267)
e3ae5bb 
* fix position access error

position is s sub attribute of _value
error since commit(id:cf48cc94d0422e6354a08765b4176552442987d5)

* lint with blank
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@lerit
fix position access error (microsoft#1267)
2f8b12b 
* fix position access error

position is s sub attribute of _value
error since commit(id:89972f6c6f9fa629b4f74093d4ba1e93c9f7a5e5)

* lint with blank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunsetWolf SunsetWolf Awaiting requested review from SunsetWolf

Assignees

@SunsetWolf SunsetWolf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lerit @you-n-g @SunsetWolf