-
Notifications
You must be signed in to change notification settings - Fork 133
linux-arm64 For Raspberry Pi 4 Support #2073
base: master
Are you sure you want to change the base?
Conversation
@@ -25,7 +25,7 @@ | |||
<Compile Remove="Models\GenericParameterModel.cs" /> | |||
</ItemGroup> | |||
<ItemGroup> | |||
<PackageReference Include="LiteDB" Version="4.1.4" /> | |||
<PackageReference Include="LiteDB" Version="5.0.8" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these upgrades required, or just the addition of arm64? This LiteDB upgrade contains breaking format changes that will break the existing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package upgrades seem unnecessary if this change is about adding arm64 support.
I'd probably separate package upgrades from just adding the platform. Also, adding new platform won't make LS load in Python Extension since it does its own platform checks and may or may not permit ARM. Extension needs to be modified to properly calculate URL for the ARM download. |
https://github.com/microsoft/vscode-python/blob/master/src/client/activation/languageServer/languageServerPackageService.ts#L39 Downloading https://pvsc.azureedge.net/python-language-server-stable/Python-Language-Server-linux-x64.0.5.50.nupkg... |
My current solution: Add linux-arm64 RuntimeIdentifiers and Build
Replace the output to the directory Add permissions
Normal after reopen vscode |
For what it's worth - and at the risk of introducing scope creep ...... linux-arm64 (in this case, native Linux on arm64/aarch64 on a Raspberry Pi...) ... But would this also work for Windows on ARM? And especially WSL2 on ARM? Given that Microsoft has doubled-down on ARM (you gotta be pretty serious to make a custom processor and not something off-the-shelf), it seems wise to ensure that this runs not only on linux-arm64 but wsl2-arm64 win-arm64, etc. |
Have you tried Pylance LS? It is in typescript so should run on any platform. https://devblogs.microsoft.com/python/announcing-pylance-fast-feature-rich-language-support-for-python-in-visual-studio-code/ |
Passed on VSCode Remote SSH to Ubuntu 20.04 LTS For Raspberry Pi 4 aarch64