Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Make sure that any folder ending with site-packages is considered a library. Fixes #854 #877

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

fabioz
Copy link
Contributor

@fabioz fabioz commented Oct 4, 2018

Note that I haven't actually changed ptvsd not to issue CMD_SET_PROJECT_ROOTS as many tests have to be updated and I saw that there's a pull request open related to that.

I'm still a little unsure if this is actually the root cause for #854 as from my tests the location mentioned on it (/Users/vsts/Library/Python/3.7/lib/python/site-packages) already seemed to be treated as a library, so, it's possible this still doesn't fix the root cause (although I think it's a step in the right direction anyways and it should handle /usr/local/lib/python3.7/site-packages which wasn't really there and I could not find out a better heuristic to find about it).

@codecov-io
Copy link

Codecov Report

Merging #877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   56.93%   56.93%           
=======================================
  Files          30       30           
  Lines        4177     4177           
=======================================
  Hits         2378     2378           
  Misses       1799     1799

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf4297...514bdf4. Read the comment docs.

@karthiknadig karthiknadig merged commit 8fd2c74 into microsoft:master Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants