This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Adds debug console completion #772
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dc867c6
Add support for debug console completion
karthiknadig 3e17f4d
Add test files
karthiknadig 2822101
Adding tests
karthiknadig d3295b7
Add supportsCompletionsRequest to _requests
karthiknadig c4858f1
Add test for bad request
karthiknadig 3c3438d
Fix sorting issue in test
karthiknadig 5a56dfc
Address comments
karthiknadig f725030
Remove unsupported test for completions
karthiknadig b0d721e
Add required argument to completions request in tests
karthiknadig b7f6144
Fix linter issues
karthiknadig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
tests/resources/system_tests/test_completions/attach_completions.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import sys | ||
import ptvsd | ||
|
||
ptvsd.enable_attach((sys.argv[1], sys.argv[2])) | ||
ptvsd.wait_for_attach() | ||
|
||
|
||
class SomeClass(): | ||
def __init__(self, someVar): | ||
self.some_var = someVar | ||
|
||
def do_someting(self): | ||
someVariable = self.some_var | ||
return someVariable | ||
|
||
|
||
def someFunction(someVar): | ||
someVariable = someVar | ||
return SomeClass(someVariable).do_someting() | ||
|
||
|
||
someFunction('value') | ||
print('done') |
16 changes: 16 additions & 0 deletions
16
tests/resources/system_tests/test_completions/launch_completions.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
class SomeClass(): | ||
def __init__(self, someVar): | ||
self.some_var = someVar | ||
|
||
def do_someting(self): | ||
someVariable = self.some_var | ||
return someVariable | ||
|
||
|
||
def someFunction(someVar): | ||
someVariable = someVar | ||
return SomeClass(someVariable).do_someting() | ||
|
||
|
||
someFunction('value') | ||
print('done') |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be outside of the function, so that the dict is not re-created for every new request.