This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Add thread count tests #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Jul 17, 2018
tests/system_tests/test_misc.py
Outdated
| session, debug_info.starttype, | ||
| breakpoints=breakpoints, | ||
| threads=True) | ||
| event = result['msg'] |
There was a problem hiding this comment.
You might want to add a delay of 1s, cuz today when you add a break point not all thread stop. So a 1s delay will ensure other thread to have hot the breakpoint and stopped.
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 60.31% 60.31%
=======================================
Files 27 27
Lines 3790 3790
=======================================
Hits 2286 2286
Misses 1504 1504Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#663