Add support for remote source references #321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 63.1% 62.46% -0.64%
==========================================
Files 14 14
Lines 2030 2057 +27
==========================================
+ Hits 1281 1285 +4
- Misses 749 772 +23
Continue to review full report at Codecov.
|
README.md
Outdated
| @@ -44,6 +44,7 @@ contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additio | |||
| "Jinja", // Enables Jinja (Flask) Template debugging | |||
| "FixFilePathCase", // See FIX_FILE_PATH_CASE in wrapper.py | |||
| "DebugStdLib" // Whether to enable debugging of standard library functions | |||
| "UseSourceReferences" // Whether to use source references (making `pathMappings` optional) | |||
There was a problem hiding this comment.
Is there any particular scenario that you have in mind when the user might want to not specify this? In VS, at least, all debuggers that support this functionality (e.g. JS), do so unconditionally.
There was a problem hiding this comment.
I couldn't think of any reason, which is why I was planning on making this the default in VSC.
There was a problem hiding this comment.
Will remove this.
ptvsd/wrapper.py
Outdated
| And we know that the path returned is the same as the server path | ||
| (i.e. path has not been translated)""" | ||
|
|
||
| if self.start_reason == 'launch' or \ |
There was a problem hiding this comment.
I wonder if it's worth disabling it for launch, given that "remote" attach can also be local - and often is in practice (e.g. for most people using our debugger with embedded Python scripting). It looks like the code below would take care of things either way?
There was a problem hiding this comment.
Sorry, but I'm not following you here.
Fixes #318
This is an opt in feature.
We'll be enabling this as a default feature in VSC.