Remove constraints on class template proxy and optimize memory layout for small VTABLE
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tian-lt
reviewed
Mar 5, 2024
tian-lt
reviewed
Mar 5, 2024
tian-lt
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VTABLE only contains 2 function pointers or less, it is not necessary to dereference through a pointer. This change allows a VTABLE to be embedded into a
proxyif small enough. The constraints on class templateproxy(basic_facade) has been removed since this optimization needs all the dispatches to be complete types beforeproxyis instantiated, whileproxy<F>is allowed to be incomplete in the definition of a dispatch.This change also improves
proxiableand corresponding helper macros. When the return type of an instantiatedoperator()of a dispatchDdoes not match the return type defined in the specific overload ofD::overload_types,proxiableused to produce a compile error. The behavior has become SFINAE-safe after this change.Resolves #69
Resolves #65