Ad-hoc recognizers #677
Merged
Ad-hoc recognizers #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omri374
requested review from
SharonHart,
navalev,
shiranr,
balteravishay and
itye-msft
and removed request for
SharonHart
omri374
commented
Apr 22, 2021
navalev
reviewed
Apr 25, 2021
navalev
previously approved these changes
Apr 25, 2021
SharonHart
reviewed
Apr 25, 2021
presidio-analyzer/presidio_analyzer/nlp_engine/spacy_nlp_engine.py
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/analyzer/adding_recognizers.md
|
@navalev and @SharonHart please re-review. Added some tests and did some better exception handling. |
|
@navalev any suggestions for the name? |
for lack of better name, lets use ad-hoc :) |
navalev
previously approved these changes
May 4, 2021
…residio into feature/ad_hoc_recos
navalev
approved these changes
May 4, 2021
SharonHart
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the option to add recognizers (regex/deny-list) only in the context of one request.
This allows user to define their own recognizers without having to write code nor redeploy the service, similar to the capability in V1.
Main difference from V1 is that there is no persistency of these recognizers and each request would have to contain the list of recognizers it needs for PII identification. The V1 recognizer store capability is in our future roadmap.
Added:
ad_hoc_recognizersparameter toAnalyzerEngine.analyzeAnalyzerRequest